Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mongodb configuration -- refactor #12

Open
jeremydouglass opened this issue Aug 5, 2018 · 3 comments
Open

mongodb configuration -- refactor #12

jeremydouglass opened this issue Aug 5, 2018 · 3 comments

Comments

@jeremydouglass
Copy link
Contributor

Mongodb config is for "localhost" and this appears throughout the code rather than in a configuration setting. In our container stack it needs to be "mongodb"

We should refactor the host setting to a configuration variable, and determine the easiest way to support both localhost anaconda development and docker deployment.

@jeremydouglass
Copy link
Contributor Author

For a reference example of a more fully-featured custom mongodb setup for docker, see:

@jeremydouglass jeremydouglass changed the title Mongodb configuration -- refactor mongodb configuration -- refactor Aug 5, 2018
@jeremydouglass
Copy link
Contributor Author

Currently this is handled by deploy-fix.sh being run by the Dockerfile to change

mongodb://localhost --> mongodb://mongo

Added in 5db5e71

@jeremydouglass
Copy link
Contributor Author

I've just noticed that this was already documented in closed issue #8

...however I think that changing from search-and-replace to an actual configuration option should stay on our to-do list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant