Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic error with custom error codes and gsub #1

Open
jasonadamyoung opened this issue Sep 29, 2010 · 0 comments
Open

Logic error with custom error codes and gsub #1

jasonadamyoung opened this issue Sep 29, 2010 · 0 comments

Comments

@jasonadamyoung
Copy link

Using 97, 98, and 99 with the line 144: code = code.gsub(/./,'')[1..2] results in what you'd expect, the code is gsub'd into 7,8,9 - resulting in unknown for any calls to the .reason method

I didn't know how you'd best like to fix this, so I didn't fork and patch. I just changed the codes to 9.9.7, 9.9.8 and 9.9.9 in my local copy just for uniformity with the smtp codes. (we get a lot of vacation replies and getting the reason string out is useful).

(thanks for this plugin btw, it's going to be helpful for us!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant