Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the Public Key of the account used during Login as part of the LoginResult #72

Open
aaroncox opened this issue Aug 24, 2023 · 1 comment
Assignees
Milestone

Comments

@aaroncox
Copy link
Member

Relevant conversation on Telegram starting here:

https://t.me/wharfkit/1163

Research will be needed to figure out an appropriate path to return this data, preferably without extra API calls.

@aaroncox aaroncox self-assigned this Aug 24, 2023
@aaroncox aaroncox removed this from Wharf v1.0 Aug 30, 2023
@aaroncox aaroncox added this to the Unscheduled milestone Aug 30, 2023
aaroncox added a commit that referenced this issue Aug 30, 2023
@aaroncox
Copy link
Member Author

As a step forward in this, a WalletPlugin may optionally now return an IdentityProof that's made available to the application. This isn't a hard requirement though, and not all wallet plugins will sign transactions during the login process.

aaroncox added a commit that referenced this issue Nov 10, 2023
* Added MOCK_DIR to coverage build

* Allow passing a `ChainDefinition` to login as `chain`

* Remove broken browser test build

* Allow passing in Contract instances for ABI caching

* Version 1.1.0-rc1

* Version 1.1.0-rc2

* Updating dependencies

* Updated tests for compressed transactions

* Added package resolution for next build

* Moved ABICache mechanisms out to its own function

Also implemented caching from embedded Action objects from new wharfkit/antelope release.

* Updating dependencies and tests for ABI caching

* Each `WalletPlugin` may optionally return an `IdentityProof`

Related to #72

* Allow calling `restore` with a `ChainDefinition`

Fixes #71

* Updating Antelope library

* New test account

* New `setAsDefault` parameter during login

Allows the developer during a `login` call to specify whether or not this account should be the new default for `restore`. Defaults to true.

* Support for Account Creation Plugins (#84)

* chore: added account-creation plugins

* fix: getting createAccount method working

* fix: fixed prompts

* fix: adding account creation plugins to context

* fix: adding account creation method to ui interface

* chore: added onAccountCreateComplete

* Ran `make format`

* Linting

* Require a name for creation services

* Mocked account creation methods in tests

* Linting

* Removed selected plugin from context

* Swapped chain to Checksum256Type

* Removed chains

* Linting

* Removed chains from options

This adds a lot of complexity for very little gain in the account creation flow.

* Reworked createAccount flow

* Version 1.1.0-rc3

* Allow developer to override chain/plugin for Account Creation

* Version 1.1.0-rc4

* Filter chains based on plugin capabilities, if set

---------

Co-authored-by: Aaron Cox <[email protected]>

* Updating dependencies for 1.1.0

* Added missing mock data

---------

Co-authored-by: Daniel Fugere <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant