Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

databits should be bytesize #13

Open
whaleygeek opened this issue Aug 3, 2017 · 0 comments
Open

databits should be bytesize #13

whaleygeek opened this issue Aug 3, 2017 · 0 comments

Comments

@whaleygeek
Copy link
Owner

whaleygeek commented Aug 3, 2017

The get_serial() inside bitio/__init__.py uses s.databits as a configuration property.

pyserial has no missing attribute protection in it's class, so this just sets an attribute on the class that is never used internally.

pyserial uses bytesize internally, and this defaults to 8 bits (which is what we assume, and what the majority of all UART configurations use these days). micro:bit also always uses 8 bits.

However, for completeness, this should be fixed.

s.databits = serial.EIGHTBITS

should be:

s.bytesize = serial.EIGHTBITS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant