Adjust rail alignments with updated EEA template and correct variables in Air alignments #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the changes to the DF7_10 Major Railways Excel template in the corresponding HSD JSON schema. SVC-1872
Implement changes required by the change of the DF7_10 Major Rail Excel template. SVC-1872
Previously, the freetext limit was set to 10.000 characters. EEA updated this limit to 4.000 characters. This is changed here for the two air alignments. The maximum URL length is configurable via the project variable `MAX_URL_LENGTH`. The respective variable is added here to the two air alignments and the value set to the EEA limit 2100. SVC-1872
florianesser
requested changes
Aug 29, 2024
|
@annat2022 Sorry, false alarm. I somehow failed to update my local branch correctly and tested an old version. After updating the branch, the problem went away. |
When the operator `&&` in a multi-line boolean expression is not and the end of the first line but added to the beginning of the second line, evaluation will fail with an `unexpected token` message. SVC-1872
florianesser
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
I fixed one problem caused by my suggestion to remove the brackets in the urlCheck function.
Otherwise LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SVC-1872