Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update library version to 1.1 #4

Merged

Conversation

emanuelaepure10
Copy link

Update library version to 1.1

ING-4043

Update library version to 1.1

ING-4043
@emanuelaepure10
Copy link
Author

emanuelaepure10 commented Dec 13, 2023

Is this change enough @stempler / @florianesser to be able to update hale-platform to use version 1.1

bundle group: 'com.github.wetransform-os', name: 'topojson-j', version: '1.1', {
bnd {
version = '1.0.0'
symbolicName = 'com.github.wetransform-os.topojson-j'
}
}

I have created the tag 1.1 but version inside build.gradle was still 1.0,
so hale-platform couldn't find the 1.1.

@stempler
Copy link
Member

version = '1.0.0'

The bundle version should reflect the library version.

I have created the tag 1.1 but version inside build.gradle was still 1.0

I would expect jitpack not caring for the internally configured version, only for the tag. Not sure about the rules there.
We could also ditch jitpack altogether for this library, since now the library is also published to our artifactory.
The version to reference would then need to be the configured version though, i.e. 1.1-SNAPSHOT.

@emanuelaepure10
Copy link
Author

This PR contains exactly

version = '1.1-SNAPSHOT'

could you please accept it?
Thank you

@emanuelaepure10 emanuelaepure10 merged commit 864f861 into wetransform-os:master Dec 13, 2023
1 check passed
Copy link

we-release bot commented Aug 15, 2024

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@we-release we-release bot added the released label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants