Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: dockerize promcda #46

Merged
merged 1 commit into from
Aug 1, 2024
Merged

build: dockerize promcda #46

merged 1 commit into from
Aug 1, 2024

Conversation

Flaminietta
Copy link
Collaborator

Create Dockerfile and .dockerignore.
Update README.

I tested it and it ran correctly.
Screenshot 2024-07-29 at 19 10 53

Please review and test.

@Flaminietta Flaminietta added code quality quality of the code improved joss review related issues related to the review process for publication labels Jul 29, 2024
@Flaminietta Flaminietta self-assigned this Jul 29, 2024
@Flaminietta Flaminietta changed the title Dockerize ProMCDA build: dockerize promcda Jul 30, 2024
@Flaminietta Flaminietta mentioned this pull request Jul 30, 2024
Closed
@B3J4y
Copy link
Collaborator

B3J4y commented Jul 31, 2024

All calculations finished in seconds 0.6382884979248047
🥳

@Flaminietta Flaminietta mentioned this pull request Jul 31, 2024
Open
@mspada
Copy link
Collaborator

mspada commented Jul 31, 2024

All works from my side as well!

@kapil-agnihotri
Copy link
Collaborator

kapil-agnihotri commented Aug 1, 2024 •
edited
Loading

LGTM, but I did not test in my system.
May be at a later point of time, you can build the image and push it to wetransform hub.docker account (or some other account) so that anyone can just pull that image and run your application.

@Flaminietta Flaminietta merged commit 26f0185 into main Aug 1, 2024
2 checks passed
@Flaminietta Flaminietta deleted the dockerize_promcda branch August 1, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kapil-agnihotri kapil-agnihotri kapil-agnihotri approved these changes

@mspada mspada mspada approved these changes

@thorsten-reitz thorsten-reitz Awaiting requested review from thorsten-reitz

Assignees

@Flaminietta Flaminietta

Labels
code quality quality of the code improved joss review related issues related to the review process for publication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Flaminietta @B3J4y @mspada @kapil-agnihotri