Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document function arguments #24

Closed
paulrougieux opened this issue Jan 31, 2024 · 1 comment · Fixed by #40
Closed

Document function arguments #24

paulrougieux opened this issue Jan 31, 2024 · 1 comment · Fixed by #40
Assignees
Labels
code quality quality of the code improved joss review related issues related to the review process for publication

Comments

@paulrougieux
Copy link

paulrougieux commented Jan 31, 2024

  • Function arguments should be documented whenever possible. The functions in these scripts are not documented:

  • Use a tool such as pdoc or sphynx to generate the documentation automatically from function docstrings. You can create a github workflow that generates the documentation and places it on a github page.

  • Functions should be accompanied with an example of how to use them, based on a sample data set. If several function depend on each other, it is fine to group those examples under the main relevant function or object.

Related to the JOSS review openjournals/joss-reviews#6190 .

@Flaminietta Flaminietta self-assigned this Feb 2, 2024
@Flaminietta Flaminietta added the joss review related issues related to the review process for publication label Feb 2, 2024
@Flaminietta
Copy link
Collaborator

Dear Paul, I am taking care of this part at #22.

@Flaminietta Flaminietta added the code quality quality of the code improved label Feb 2, 2024
@Flaminietta Flaminietta linked a pull request Mar 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality quality of the code improved joss review related issues related to the review process for publication
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants