Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use iframes for embed[] / load[] instead of php #10

Open
itsrachelfish opened this issue Sep 27, 2015 · 0 comments
Open

Use iframes for embed[] / load[] instead of php #10

itsrachelfish opened this issue Sep 27, 2015 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@itsrachelfish
Copy link
Member

Currently to avoid cross domain rules, embedded content on the wiki is copied via a PHP script and run in the page. This means any untrusted scripts on other parts of wetfish could lead to XSS vulnerabilities in the wiki.

To avoid this, iframes should be used to embed content and the frames would automatically resize using post messages.

@itsrachelfish itsrachelfish added bug Something isn't working enhancement New feature or request labels Sep 27, 2015
@itsrachelfish itsrachelfish transferred this issue from another repository Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant