Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change app_settings.PERIODIC_TASK_SUFFIX default to an empty string #20

Open
joshuadavidthomas opened this issue Feb 16, 2024 · 0 comments
Open

Change app_settings.PERIODIC_TASK_SUFFIX default to an empty string #20

joshuadavidthomas opened this issue Feb 16, 2024 · 0 comments
Labels
🏋️ improvement Enhancements or optimizations to existing functionality 🧁 needs baking Requires more time for consideration or development before further action

Comments

@joshuadavidthomas
Copy link
Member

Since we've moved to tracking the registered task via a Task model, there's not really a need to have the suffix on the Schedule -- it was used to filter out schedules that were not managed by django-q-registry.

I still think it might be useful to still expose the setting for users to opt-in; some people may want to see at a glance in the admin of schedules managed by this package. But it should default to be empty.
@joshuadavidthomas joshuadavidthomas added 🧁 needs baking Requires more time for consideration or development before further action 🏋️ improvement Enhancements or optimizations to existing functionality and removed enhancement labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🏋️ improvement Enhancements or optimizations to existing functionality 🧁 needs baking Requires more time for consideration or development before further action
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joshuadavidthomas