Skip to content

[Question] "Multiple" or "Multiply"? #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kevinmatthes opened this issue May 20, 2022 · 29 comments
Closed

[Question] "Multiple" or "Multiply"? #10

kevinmatthes opened this issue May 20, 2022 · 29 comments

Comments

@kevinmatthes
Copy link
Contributor

Regarding the option documentation, I am unsure whether it should rather be "multiply" instead of "multiple".

After all, the word annotates the verb "specify", right? From my point of view, this would actually require an adverb... Did you already check it with languagetool or so?

If a change should be necessary, I would suggest to add it to #9.

@wert007
Copy link
Owner

wert007 commented May 20, 2022

multiple, since it reads more like "multiple values specified".

@kevinmatthes
Copy link
Contributor Author

And did you languagetool it or something similar?

Furthermore, why do the descriptions use French Spacing although English in general does not?

@kevinmatthes
Copy link
Contributor Author

Another point: should not the option descriptions rather use Imperative / Present instead of Indicative / Simple Present, as Cargo does it, for example?

@kevinmatthes
Copy link
Contributor Author

Regarding #7, I just added the description for --help to #9 since it already applies Imperative / Present.

@wert007
Copy link
Owner

wert007 commented May 21, 2022

And did you languagetool it or something similar?

I asked @Ranplax

Furthermore, why do the descriptions use French Spacing although English in general does not?

I'm not sure what you mean by French Spacing 😅

@wert007
Copy link
Owner

wert007 commented May 21, 2022

Another point: should not the option descriptions rather use Imperative / Present instead of Indicative / Simple Present, as Cargo does it, for example?

I guess you are right. I just wrote them without overthinking them too much 😅

@kevinmatthes
Copy link
Contributor Author

French Spacing is a LaTeX feature. In languages like English or Italian, it is common to place two space characters after finishing a phrase (. ! ? : ‽ ...). Languages like French or German just place one space character after a phrase was ended. LaTeX's babel cares for the correct style, by default.

But when authoring software, software engineers need to care for this convention themselves since there is no LaTeX to fix it automatically (except for Doxygen but only in PDF mode). This is why I would like to outline that we need to agree on how to handle French Spacing.

For instance, my fixes of the usage function do not use French Spacing (Usage: commit-analyzer) which is correct in the terms of English typography but your option descriptions do use French Spacing which is often considered a mistake. A common style for such things helps to keep the application's overall appearance tidy.

@wert007
Copy link
Owner

wert007 commented May 21, 2022

I see. And where exactly do we have French spacing?

@kevinmatthes
Copy link
Contributor Author

Just like Cargo's clippy lints and fixes Rust code, there are also linters for natural languages. languagetool is one of them. It is a website where you enter the text to lint and it rates whether it is correct. It supports many languages and even some common dialects of them.

Before ending up in a dispute about adverbs, such a natural language linter usually helps to solve such grammar issues since it is a neutral and objective instance.

@kevinmatthes
Copy link
Contributor Author

I see. And where exactly do we have French spacing?

In the option descriptions. Always at the beginning of the second phrase, there is just one space character.

@wert007
Copy link
Owner

wert007 commented May 21, 2022

Hmm, I can not find examples, where this is used with full stops. Do you have maybe some?

1 similar comment
@wert007
Copy link
Owner

wert007 commented May 21, 2022

Hmm, I can not find examples, where this is used with full stops. Do you have maybe some?

@kevinmatthes
Copy link
Contributor Author

In my fork, the first occurrence of French Spacing is at line 15 of src/main.rs:

            "Filters after certain author names. ORs if multiple specified.",

But instead, it should rather be without French Spacing:

            "Filters after certain author names.  ORs if multiple specified.",

Indeed, this is a very small detail. But it is still part of the project. And in my opinion, since we discussed whether or not to place syntactically possible but obsolete semicolons in #6, we should also care for this detail.

If you want to see the differences with and without French Spacing in action in a larger text, do the following:

  • open one of your LaTeX projects in your LaTeX IDE
  • add \frenchspacing right after \begin{document}, compile, and print one page of the resulting PDF
  • change \frenchspacing to \nonfrenchspacing, recompile, and print the same page of the resulting PDF
  • take a ruler and measure the distance between a full stop and succeeding lexeme on the same line of the same adjacent sentences

You will definitely encounter a difference. This difference should be minded when writing text in a language which does not apply French Spacing. And as I said, English is one these languages. Proof: set your babel of the concerning project to another language, and compare the differences of the results as described above, such as with british vs. ngerman, for instance.

@wert007
Copy link
Owner

wert007 commented May 22, 2022

But you are comparing here a mono spaced font with a variable spaced font. E.g. if I copy text from the English wikipedia

Computer programming is the process of performing a particular computation (or more generally, accomplishing a specific computing result), usually by designing and building an executable computer program. Programming involves tasks such as analysis, generating algorithms, profiling algorithms' accuracy and resource consumption, and the implementation of algorithms (usually in a chosen programming language, commonly referred to as coding).

There is only one space after each full stop. However that space will be rendered does not matter too much imho.

@kevinmatthes
Copy link
Contributor Author

On the other hand, avoiding of French Spacing is practiced in order to recognise the end of phrase more easily. This also holds true for source code.

@wert007
Copy link
Owner

wert007 commented May 22, 2022

On the other hand, avoiding of French Spacing is practiced in order to recognise the end of phrase more easily. This also holds true for source code.

Do you have any example of source code for that? Except of latex settings I do not really find anything for that..

@kevinmatthes
Copy link
Contributor Author

The license header of the former does not apply French Spacing and my documentation strings neither. To me, this looks more readable. Just like the GPL 2.0 itself; see the latter link for an example.

@wert007
Copy link
Owner

wert007 commented May 22, 2022

I meant in other code bases. I expected you, to use the spacing style you're advocating for.. 😅

@kevinmatthes
Copy link
Contributor Author

GNU Octave: https://github.com/gnu-octave/octave

@kevinmatthes
Copy link
Contributor Author

@kevinmatthes
Copy link
Contributor Author

The GNU Shell Intrinsics: https://github.com/coreutils/coreutils

@wert007
Copy link
Owner

wert007 commented May 22, 2022

Thanks for your examples, but I have to admit, I'm not a fan of it.

But thanks anyway, I wasn't aware, this exists. But I think we should stick with singular spaces.

@kevinmatthes
Copy link
Contributor Author

In summary:

  • 🔧 change the mode and tense to Imperative / Present
  • 🔧 revert French Spacing

By the way what did languagetool or any other English linter say to "ORs if multiple specified."?

@wert007
Copy link
Owner

wert007 commented May 22, 2022

Yes.

I didn't ask it. I'm open to other wordings in general though. But I'm pretty sure, that multiple is correct, since it is not referring to "specified".

@kevinmatthes
Copy link
Contributor Author

And to which actually contained word it refers if not to specified?

@wert007
Copy link
Owner

wert007 commented May 22, 2022

multiple, since it reads more like "multiple values specified".

An implied "values"

@kevinmatthes
Copy link
Contributor Author

languagetool accepts both; how about just changing the wording to clarify? To me, it still looks like "multiple" refers to "specified".

How about "ORs if specified multiple times"?

@wert007
Copy link
Owner

wert007 commented May 22, 2022

"ORs if specified multiple times" sounds good 👍

@kevinmatthes
Copy link
Contributor Author

Fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants