Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

template_flow method should be outside the client #528

Open
Sandro-Meireles opened this issue Jan 5, 2023 · 0 comments
Open

template_flow method should be outside the client #528

Sandro-Meireles opened this issue Jan 5, 2023 · 0 comments

Comments

@Sandro-Meireles
Copy link
Contributor

Ideally, the FlowsRESTClient class should have a clear responsibility: contain flow clients

The template_flow method appears to be out of place among the clients. Furthermore, the name is not very suggestive either
https://github.com/weni-ai/weni-engine/blob/main/connect/api/v1/internal/flows/flows_rest_client.py#L341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sandro-Meireles