Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config file to sage (just as remotepy does) #6

Open
ArneRobben opened this issue Jul 21, 2023 · 1 comment
Open

add config file to sage (just as remotepy does) #6

ArneRobben opened this issue Jul 21, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@ArneRobben
Copy link
Contributor

ArneRobben commented Jul 21, 2023

The command

sage deploy pytorch text-classification arn:aws:iam::xxxxxxxxxxxx:role/service-role/AmazonSageMaker-ExecutionRole-xxxxxxxxxxxx--model-path s3://datalabs-data/sagemaker_test/dummy.pt.tar.gz --endpoint-name test --instance-type ml.t2.medium --entry-point sage/example_entrypoints/pytorch_dummy_entrypoint.py

(with arn:aws:iam::xxxxxxxxxxxx my role number)
works neatly for me now!

It does make me think is quite a faff to write all arguments. I really like the way Matt's remotepy (https://github.com/ivyleavedtoadflax/remote.py/blob/main/remotepy/config.py) uses a config file to store variables which repeat regulary, in this case, it could be the arn role but even the s3 bucket or instance type

Would it be much effort to add this in? I think it would make the tool more user friendly

@ArneRobben ArneRobben added the enhancement New feature or request label Jul 21, 2023
@justinbt1
Copy link
Collaborator

How about using environment variables?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants