Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version bounds on liburing #7

Closed
phadej opened this issue Mar 14, 2024 · 3 comments
Closed

Add version bounds on liburing #7

phadej opened this issue Mar 14, 2024 · 3 comments

Comments

@phadej
Copy link
Collaborator

phadej commented Mar 14, 2024

Both lower and upper bounds

It looks like liburing is actively developed library: https://github.com/axboe/liburing/blob/1fdcca14b9af2daea50bf1f08605875ffda349e7/CHANGELOG

Especially having the lower bound on liburing is important that this library doesn't use something not present in old liburing. Testing with that version is obviously a must (e.g. using an older debian or ubuntu image).
@dcoutts
Copy link
Member

dcoutts commented Mar 15, 2024

Yeah, and it should be easy since it uses pkg-config.

@phadej
Copy link
Collaborator Author

phadej commented Mar 20, 2024

Note, Ubuntu 22.04 LTS (jammy) uses 2.1 https://packages.ubuntu.com/jammy/liburing2

dcoutts added a commit that referenced this issue Mar 20, 2024
@dcoutts
Support liburing >= 2.0 && < 2.7
031c35f 
So we can work with the system liburing in more cases.

Fixes issue #7
@dcoutts dcoutts mentioned this issue Mar 20, 2024
Merged
@dcoutts
Copy link
Member

dcoutts commented Mar 20, 2024

Fixed by #9.

@dcoutts dcoutts closed this as completed Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phadej @dcoutts