-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A plot_results function that works across predict* functions and multiple annotation types. #768
Conversation
fbf91ef
to
c4b33dd
Compare
@ethanwhite this is ready for review. There is one backwards compatibility error. Within the predict_* functions, there is no longer a return_plot argument. This seemed cleaner than adding a deprecation. |
Quick demo is within the doc build see docs/advanced_features/visuzalization.md in the readthedoc build https://deepforest--768.org.readthedocs.build/en/768/advanced_features/visualizations.html
|
Add root_dir as a class attribute of a prediction dataframe through pandas. Remove the root_dir argument from plot_results. |
Make the visualizations larger. on the markdown document. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really excellent work @bw4sz and a lot of it. I've done my best to review the whole thing thoroughly. Almost all of the comments are minor cleanup, with the one slightly more major thing being a small change to how multi-class colors are handled. Let me know if you have any questions.
@bw4sz - is this ready for me to give it another look? |
yes, the error I see is not related.
…On Thu, Sep 19, 2024 at 5:46 AM Ethan White ***@***.***> wrote:
@bw4sz <https://github.com/bw4sz> - is this ready for me to give it
another look?
—
Reply to this email directly, view it on GitHub
<#768 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJHBLDWFJKLDIMO4EN4G3LZXLBSJAVCNFSM6AAAAABNVGTQMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRQHA4TCNZUGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Ben Weinstein, Ph.D.
Research Scientist
University of Florida
|
…emove plotting from predict functions, closes #761 and update docs
b837a56
to
abe8c6e
Compare
@ethanwhite I rebased and this should be ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks great. There was one remaining issue with our color handling in plot_results (my fault, I didn't have the fix quite right in my review). I just submitted a PR against this branch that I think fixes it.
@bw4sz - take a look at that PR and if everything looks good merge it and then we can get this merged.
We were checking results_color, which will typically be a length 3 list. This would cause incorrect behavior in the presence of multiple labels. This switches to always creating results_color_sv upfront and checking it. Also adds some type/value checks to the input.
Quick roadmap for a number of visualization related issues.