Skip to content

Commit 554061b

Browse files
committed
phpunit9用に改修、コードフォーマッタ適用
1 parent d5b9358 commit 554061b

26 files changed

+51
-13
lines changed

ConsoleOutputStream.php

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
23
namespace WebStream\IO;
34

45
/**

File.php

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
23
namespace WebStream\IO;
34

45
use WebStream\Exception\Extend\IOException;

FileInputStream.php

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
23
namespace WebStream\IO;
34

45
use WebStream\Exception\Extend\InvalidArgumentException;

FileOutputStream.php

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
23
namespace WebStream\IO;
34

45
use WebStream\IO\OutputStream;

InputStream.php

+8
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
23
namespace WebStream\IO;
34

45
use WebStream\Exception\Extend\IOException;
@@ -62,6 +63,13 @@ abstract public function close();
6263
*/
6364
abstract public function read($length = null);
6465

66+
/**
67+
* 入力ストリームから行単位でデータを読み込む
68+
* 末尾に改行コードは含まない
69+
* @return string 読み込みデータ
70+
*/
71+
abstract public function readLine();
72+
6573
/**
6674
* 入力ストリームから指定バイト数後方へポインタを移動する
6775
* @param int $pos 後方への移動バイト数(負数の場合は前方へ移動)

OutputStream.php

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
23
namespace WebStream\IO;
34

45
/**

Reader/FileReader.php

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
23
namespace WebStream\IO\Reader;
34

45
use WebStream\IO\FileInputStream;

Reader/InputStreamReader.php

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
23
namespace WebStream\IO\Reader;
34

45
use WebStream\IO\InputStream;

StringInputStream.php

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
23
namespace WebStream\IO;
34

45
use WebStream\Exception\Extend\InvalidArgumentException;

Test/FileReaderTest.php

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
23
namespace WebStream\IO\Test;
34

45
require_once dirname(__FILE__) . '/../InputStream.php';

Test/FileTest.php

+7-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
23
namespace WebStream\IO\Test;
34

45
require_once dirname(__FILE__) . '/../File.php';
@@ -211,24 +212,27 @@ public function okLastModified($file)
211212
* ファイルのリネームに失敗すること
212213
* @test
213214
* @dataProvider renameFailureProvider
214-
* @expectedException WebStream\Exception\Extend\IOException
215215
*/
216216
public function ngFileRename($file)
217217
{
218+
$this->expectException(\WebStream\Exception\Extend\IOException::class);
219+
218220
chmod($file->getFilePath(), 0444);
219221
$file->renameTo("/tmp/file-test-rename/" . $file->getFileName());
222+
$this->fail();
220223
}
221224

222225
/**
223226
* 異常系
224227
* 絶対ファイルパスを取得できず例外が発生すること
225228
* @test
226-
* @expectedException WebStream\Exception\Extend\IOException
227229
*/
228230
public function ngFileAbsolutePath()
229231
{
232+
$this->expectException(\WebStream\Exception\Extend\IOException::class);
233+
230234
$file = new File("/tmp/dummy.txt");
231235
$file->getAbsoluteFilePath();
232-
$this->assertTrue(false);
236+
$this->fail();
233237
}
234238
}

Test/FileWriterTest.php

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
23
namespace WebStream\IO\Test;
34

45
require_once dirname(__FILE__) . '/../InputStream.php';

Test/Fixtures/file-test1.txt

100644100755
File mode changed.

Test/InputStreamReaderTest.php

+5-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
<?php
2+
23
namespace WebStream\IO\Test;
34

5+
require_once dirname(__FILE__) . '/../File.php';
46
require_once dirname(__FILE__) . '/../InputStream.php';
57
require_once dirname(__FILE__) . '/../FileInputStream.php';
68
require_once dirname(__FILE__) . '/../StringInputStream.php';
@@ -151,12 +153,13 @@ public function okMarkAndReset($stream, $skipNum, $result)
151153
* 読み込みサイズに不正値を渡した時、例外が発生すること
152154
* @test
153155
* @dataProvider invalidLengthProvider
154-
* @expectedException WebStream\Exception\Extend\InvalidArgumentException
155156
*/
156157
public function ngInvalidLength($stream)
157158
{
159+
$this->expectException(\WebStream\Exception\Extend\InvalidArgumentException::class);
160+
158161
$reader = new InputStreamReader($stream);
159162
$reader->read("dummy");
160-
$this->assertTrue(false);
163+
$this->fail();
161164
}
162165
}

Test/Modules/IOException.php

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
23
namespace WebStream\Exception\Extend;
34

45
/**

Test/Modules/InvalidArgumentException.php

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
23
namespace WebStream\Exception\Extend;
34

45
/**

Test/OutputStreamWriterTest.php

+10-6
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
23
namespace WebStream\IO\Test;
34

45
require_once dirname(__FILE__) . '/../File.php';
@@ -229,23 +230,25 @@ public function okConsoleWriteOffsetLength()
229230
* 異常系
230231
* ファイルオブジェクト、ファイルパス以外を指定した場合、例外が発生すること
231232
* @test
232-
* @expectedException WebStream\Exception\Extend\InvalidArgumentException
233233
*/
234234
public function ngInvalidFileType()
235235
{
236+
$this->expectException(\WebStream\Exception\Extend\InvalidArgumentException::class);
237+
236238
$stream = new FileOutputStream(1);
237-
$this->assertTrue(false);
239+
$this->fail();
238240
}
239241

240242
/**
241243
* 異常系
242244
* ファイルがロックされている状態でストリームオブジェクトを作成した場合、例外が発生すること
243245
* @test
244246
* @dataProvider writeProvider
245-
* @expectedException WebStream\Exception\Extend\IOException
246247
*/
247248
public function ngAlreadyFileLocked($filePath)
248249
{
250+
$this->expectException(\WebStream\Exception\Extend\IOException::class);
251+
249252
@unlink($filePath);
250253
// ファイルを作る
251254
$stream = new FileOutputStream($filePath);
@@ -259,18 +262,19 @@ public function ngAlreadyFileLocked($filePath)
259262
flock($resource, LOCK_EX);
260263

261264
new FileOutputStream($filePath);
262-
$this->assertTrue(false);
265+
$this->fail();
263266
}
264267

265268
/**
266269
* 異常系
267270
* flush済みの状態でflushすると例外が発生すること
268271
* @test
269272
* @dataProvider writeProvider
270-
* @expectedException WebStream\Exception\Extend\IOException
271273
*/
272274
public function ngInvalidFlush($filePath)
273275
{
276+
$this->expectException(\WebStream\Exception\Extend\IOException::class);
277+
274278
@unlink($filePath);
275279
$stream = new FileOutputStream($filePath);
276280
$writer = new OutputStreamWriter($stream);
@@ -279,6 +283,6 @@ public function ngInvalidFlush($filePath)
279283
$writer->close();
280284

281285
$writer->flush();
282-
$this->assertTrue(false);
286+
$this->fail();
283287
}
284288
}

Test/Providers/FileProvider.php

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
23
namespace WebStream\IO\Test\Providers;
34

45
use WebStream\IO\File;

Test/Providers/FileReaderProvider.php

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
23
namespace WebStream\IO\Test\Providers;
34

45
/**

Test/Providers/FileWriterProvider.php

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
23
namespace WebStream\IO\Test\Providers;
34

45
/**

Test/Providers/InputStreamReaderProvider.php

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
23
namespace WebStream\IO\Test\Providers;
34

45
use WebStream\IO\FileInputStream;

Test/Providers/OutputStreamWriterProvider.php

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
23
namespace WebStream\IO\Test\Providers;
34

45
use WebStream\IO\FileOutputStream;

Writer/FileWriter.php

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
23
namespace WebStream\IO\Writer;
34

45
use WebStream\IO\FileOutputStream;

Writer/OutputStreamWriter.php

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<?php
2+
23
namespace WebStream\IO\Writer;
34

45
use WebStream\IO\OutputStream;

Writer/SimpleFileWriter.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
<?php
2+
23
namespace WebStream\IO\Writer;
34

45
use WebStream\IO\File;
5-
use WebStream\IO\FileOutputStream;
66
use WebStream\Exception\Extend\IOException;
77

88
/**

composer.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
22
"require": {
3-
"phpunit/phpunit": "6.*"
3+
"phpunit/phpunit": "9.*"
44
}
55
}

0 commit comments

Comments
 (0)