Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom codecs conflict with default ones #651

Open
brzep opened this issue Jan 24, 2025 · 0 comments
Open

custom codecs conflict with default ones #651

brzep opened this issue Jan 24, 2025 · 0 comments

Comments

@brzep
Copy link

brzep commented Jan 24, 2025

I came across this issue while developing an app using webrtc-rs. After creating MediaEngine, I call register_default_codecson it. Then I callregister_codec` twice, registering codecs that I use in my app, with custom payload types.

When I was testing a connection with one service, it consistently failed, signaling an invalid sdp offer. It turned out, that there was more than one line that was mapping payload type to certain codec, eg. a=rtpmap:96 H264/90000. To fix this I just stopped registering default codecs, because it doesn't make any sense for me to do this anyway.

Shouldn't the library prevent such behavior? Maybe throw some error when registering conflicting payload types?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant