Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphQL::setPromiseAdapter() considered deprecated? #735

Closed
vhenzl opened this issue Nov 18, 2020 · 1 comment · Fixed by #902
Closed

GraphQL::setPromiseAdapter() considered deprecated? #735

vhenzl opened this issue Nov 18, 2020 · 1 comment · Fixed by #902
Labels
enhancement

Comments

@vhenzl
Copy link
Contributor

vhenzl commented Nov 18, 2020

As per this comment, I'm wondering if GraphQL::setPromiseAdapter(), and Executor::setPromiseAdapter() and Executor::getPromiseAdapter() shouldn't be deprecated.

Seems logical as GraphQL::execute() and GraphQL::executeAndReturnResult() have been deprecated a long time ago, GraphQL::promiseToExecute() doesn't need them and GraphQL::executeQuery() doesn't use them.

Having them deprecated would IMO make more obvious how to set up custom promise adapters correctly.

Context: overblog/dataloader-php#39. Also related to #664.
@vladar
Copy link
Member

vladar commented Jan 23, 2021

Yes, we should deprecate it. A PR is welcome!

spawnia added a commit that referenced this issue Jul 29, 2021
@spawnia
Remove GraphQL::setPromiseAdapter()
a51aa65 
#735
@spawnia spawnia mentioned this issue Jul 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove GraphQL::setPromiseAdapter() webonyx/graphql-php
3 participants
@vladar @vhenzl @spawnia