-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename destroy() to dispose() #756
Comments
I'm unsure how WebNN's "destroy()" meaning differs from WebGPU's "destroy()" to justify a new name. Web developers should be familiar with "destroy" meaning delayed destruction. I could see |
Bikeshedding: we could also use This would align with Symbol.dispose from https://github.com/tc39/proposal-explicit-resource-management |
I have to say I don't feel particularly strongly about any of |
Could we address this by updating the |
I agree that if most of the platform (particularly WebGPU) has chosen If there are no objections I am going to close this issue and paint the word "destroy" on the side of the bike shed. |
I don't see any objections, so I'm going to close this on @reillyeon's behalf. Please comment or re-open if more discussion is warranted. |
Since in many cases a resource continues to exist for a period of time while processing finishes I think it will be less confusing to developers to name these methods
release()
.The text was updated successfully, but these errors were encountered: