Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DML] Using DirectMLX.h can't set roundingType or outputSizes for pool2d #184

Closed
mingmingtasd opened this issue Dec 24, 2021 · 1 comment

Comments

@mingmingtasd
Copy link
Collaborator

mingmingtasd commented Dec 24, 2021

Failed to run Pool2d tests with outputSizes [4,4] or roundingType as ceil on DML.
These following six tests could run pass by native OpenVINO backend, while run fail by native DML backend

[  FAILED  ] Pool2dTests.MaxPool2dAutoPadExplicitOutputSizes4x4Nhwc
[  FAILED  ] Pool2dTests.MaxPool2dAutoPadExplicitRoundingTypeCeilNhwc
[  FAILED  ] Pool2dTests.AveragePool2dAutoPadExplicitOutputSizes4x4Nhwc
[  FAILED  ] Pool2dTests.AveragePool2dAutoPadExplicitRoundingTypeCeilNhwc
[  FAILED  ] Pool2dTests.l2Pool2dPadsOutputSizes4x4
[  FAILED  ] Pool2dTests.l2Pool2dPadsRoundingTypeCeil

Their output data are not as expected.

This issue would also make test them fail by Node binding for DML backend.

DirectML native API requires the output tensor shape which contains the outputSizes, it will not use roundingType as parameter since outputSizes can already predict the roundingType.
While using DirectMlX.h as the wrapper of DirectML native API, we can't set correct outputSizes which need to match the specified roundingType. Using DirectMlX.h will let pool2d perform as specifying floor roundingType.
Fixing this issue will depend on #172 to remove DirectMLX.h.

@mingmingtasd
Copy link
Collaborator Author

Also track in DirectML github: microsoft/DirectML#205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant