Allow event blank and fix 500 bug (#3832)

* Allow event blank and fix 500 bug

* Fixes 500 on survey template

Author: jonasdeluna

lego/apps/surveys/migrations/0016_alter_survey_event.py

@@ -0,0 +1,25 @@
+# Generated by Django 4.2.16 on 2025-04-17 13:42
+
+import django.db.models.deletion
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("events", "0043_alter_registration_presence_and_more"),
+        ("surveys", "0015_alter_survey_options"),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name="survey",
+            name="event",
+            field=models.OneToOneField(
+                blank=True,
+                null=True,
+                on_delete=django.db.models.deletion.CASCADE,
+                to="events.event",
+            ),
+        ),
+    ]

lego/apps/surveys/models.py

@@ -30,7 +30,9 @@ class Survey(BasisModel):
         max_length=30, choices=EVENT_TYPES, null=True, blank=True, unique=False
     )
     is_template = models.BooleanField(default=False, null=False)
-    event = models.OneToOneField("events.Event", on_delete=models.CASCADE, null=True)
+    event = models.OneToOneField(
+        "events.Event", on_delete=models.CASCADE, null=True, blank=True
+    )
     sent = models.BooleanField(default=False)
     token = models.CharField(
         max_length=64, default=None, unique=True, null=True, blank=True

lego/apps/surveys/permissions.py

@@ -61,7 +61,7 @@ def has_perm(
                     survey = queryset.get(id=survey_pk)
                 except queryset.model.DoesNotExist:
                     survey = None
-            if survey and user:
+            if survey and user and survey.event:
                 user_attended_event = survey.event.registrations.filter(
                     user=user.id, presence=PRESENCE_CHOICES.PRESENT
                 ).exists()
@@ -126,9 +126,10 @@ def has_perm(
 
             survey_pk = view.kwargs["survey_pk"]
             survey = Survey.objects.get(id=survey_pk)
-            user_attended_event = survey.event.registrations.filter(
-                user=user.id, presence=PRESENCE_CHOICES.PRESENT
-            ).exists()
+            if survey.event:
+                user_attended_event = survey.event.registrations.filter(
+                    user=user.id, presence=PRESENCE_CHOICES.PRESENT
+                ).exists()
 
         if is_survey_admin:
             return True