feat: add PB page migration #4471
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I decided to not go through with this PR, as in some mid-term future we want to migrate Page Builder to use CMS as a storage layer, so this migration is just a waste of time and an unnecessary risk (no matter how low the risk is). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds a PB Pages migration, which moves page attributes from the root of the dynamo entity to the
dataenvelope. This makes adding new attributes much easier, and will not require updates to the Entity definition in the future.In the storage operations, all actions performed against Dynamo DB now include a compatibility layer, which ensures that the data is written to both the root of the record and the new
dataattribute. Once we get to 5.43., this compatibility layer can be removed.TODO: PB Blocks migration to achieve the same goal.
How Has This Been Tested?
Jest tests and manually.