Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use globals for generating PSR request #15

Open
lruozzi9 opened this issue Oct 17, 2023 · 0 comments
Open

Do not use globals for generating PSR request #15

lruozzi9 opened this issue Oct 17, 2023 · 0 comments

Comments

@lruozzi9
Copy link
Member

Currently, this translation is handled by the $serverRequest = ServerRequest::fromGlobals(); line that uses the global PHP vars, but this could be a limit, especially for testing purposes. In behat there is not a real HTTP request, so we should remove the use of these globals.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lruozzi9