Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of common attribute of type "image" #94

Open
jorgerucoba opened this issue Jun 25, 2021 · 1 comment
Open

Handling of common attribute of type "image" #94

jorgerucoba opened this issue Jun 25, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@jorgerucoba
Copy link

Hey there!
I am dealing with the following situation: In Akeneo I have a product model with a variant of 1 axis. The product model has a common attribute named Image, and the axis has another attribute named ImageVariant.
When I import them to Sylius, the common Image gets imported n times as existent variants.

Shouldn't it get imported only once, as it is a common attribute?

This is how I configured the import of those attributes in webgriffe_sylius_akeneo_plugin.yaml

        image:
            type: 'image'
            options:
                akeneo_attribute_code: 'image'
                sylius_image_type: 'image'        
                
        image_variant:
            type: 'image'
            options:
                akeneo_attribute_code: 'variation_image'
                sylius_image_type: 'variation_image'`

Have I mistaken something in my configuration? Or is it a matter of enhancement of the plugin. Thanks in advance.

Best regards.

@jorgerucoba jorgerucoba changed the title Handling of common attributes Handling of common attribute of type "Image" Jun 25, 2021
@jorgerucoba jorgerucoba changed the title Handling of common attribute of type "Image" Handling of common attribute of type "image" Jun 25, 2021
@mmenozzi
Copy link
Member

Hi @jorgerucoba,
we didn't tested this behavior yet but if it's like you say this sounds like a bug.

I don't know when we're be able to fix it. If you need it fixed soon feel free to provide a PR.

Thank you for your feedback anyway.

@mmenozzi mmenozzi added the bug Something isn't working label Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants