Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use liip_imagine to map product's image #83

Closed
maxmishyn opened this issue Apr 19, 2024 · 1 comment · Fixed by #85
Closed

Use liip_imagine to map product's image #83

maxmishyn opened this issue Apr 19, 2024 · 1 comment · Fixed by #85
Labels
enhancement New feature or request

Comments

@maxmishyn
Copy link

Currently EcommerceOrderProductMapper in getImageUrlFromPathAndChannel() method returns almost hardcoded path to the mages, what neither work with remote storages nor with non-standard (media/image/...) local paths.

I propose to use liip_imgine's CacheManager's getBrowserPath(...) method to generate the URLs. Would be good to add preferred filter name to the mapping configs in this case too. As a result, this will generate valid image URLs and it will give control over dimensions of AC synced images.

I'm adding this to the project I'm working now. Is it something what needs PR?

@maxmishyn maxmishyn added the enhancement New feature or request label Apr 19, 2024
@lruozzi9
Copy link
Member

Hi @maxmishyn. Feel free to suggest these changes on a PR, we will be glad to review and merge them! Any improvements will be at least considered! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants