Sass includePaths

[davearel]

I'm having major performance issues with the sass compiler due to a bunch of linked bower and NPM packages. The solution is to limit the sass compiler to app/styles and explicitly defined includePaths. This is done by enabling the onlyIncluded flag in ember-cli-sass (see: ember-cli-sass#usage).

I have done this, and it's significantly faster. The problem is that I can't seem to include pod-styles. Can I include a particular path in order for ember-cli-sass to pick up the pod-styles?

[webark]

the pod-styles file ends up being a manifest that is just a series of import to the path of the other existing style files. I'd say the best way initially is to try to make sure the whole app directory is included.

[davearel]

Doesn't seem to work, still getting Error: File to import not found or unreadable: pod-styles.

[webark]

hmm. I'll get a dummy app set up with that and see what's going on.

[webark]

so it looks like with the onlyIncluded setting in ember-cli-sass is resetting the input tree here.

    inputTrees = [new Funnel('app/styles', {
      srcDir: '/',
      destDir: 'app/styles',
      annotation: 'Funnel (styles)'
    })];

Since we are, during the build process, creating some of these files and merging them into the style broccoli tree(node) it get's lost here and goes back to just the actual files. I think if we where to make a change to

    inputTrees = [new Funnel(tree, {
      include: ['app/styles/**/*'],
      annotation: 'Funnel (styles)'
    })];

instead, that would fix the issue, and be more of what they wanted. I'll propose that PR a little later when I get a chance, if you don't beat me to it, and see what they say about it. We'd want to make sure that it sill maintains the performance benefits that they where after with adopted-ember-addons/ember-cli-sass#140 I think it will, but @dmfenton might be able to confirm better then I could.

[davearel]

Thanks @webark, I tested this, works great. I submitted a PR.

[webark]

@davearel just merged your pr! Thanks for submitting it! If everything works out fine, feel free to close the issue if you have a chance to, otherwise i'll get to it tomorrow. Thanks again :)

[davearel]

All good! Thanks for your help, @webark!