#24 Added new manual disposal overloads to SqlProgram. If you provide a lambda that takes an IDisposable parameter, then you can dispose the resources manually by calling Dispose() on the supplied object.

Disposal occurs automatically once command timeout +1s has elapsed, making it less likely for resource leaks to occur.

Also added an overload to the constructor of CloseableStream to accept an IDisposable directly.

Tests have been updated, as have Test databases.

Author: thargy

Database/ConcurrencyController.cs

@@ -236,7 +236,7 @@ private static void UpdateSemaphore<TId>(
         /// <exception cref="System.ArgumentNullException"><paramref name="databaseId"/> was null.</exception>
         public static AsyncSemaphore GetDatabaseSemaphore([NotNull] string databaseId)
         {
-            if (databaseId == null) throw new ArgumentNullException("databaseId");
+            if (databaseId == null) throw new ArgumentNullException(nameof(databaseId));
 
             AsyncSemaphore semaphore;
             _databaseSemaphores.TryGetValue(databaseId, out semaphore);
@@ -254,8 +254,8 @@ public static AsyncSemaphore GetLoadBalancedConnectionSemaphore(
             [NotNull] string databaseId,
             [NotNull] string connectionId)
         {
-            if (databaseId == null) throw new ArgumentNullException("databaseId");
-            if (connectionId == null) throw new ArgumentNullException("connectionId");
+            if (databaseId == null) throw new ArgumentNullException(nameof(databaseId));
+            if (connectionId == null) throw new ArgumentNullException(nameof(connectionId));
 
             AsyncSemaphore semaphore;
             _loadBalancedConnectionSemaphores.TryGetValue(new Id(databaseId, connectionId), out semaphore);
@@ -275,9 +275,9 @@ public static AsyncSemaphore GetConnectionSemaphore(
             [NotNull] string connectionId,
             [NotNull] Connection connection)
         {
-            if (databaseId == null) throw new ArgumentNullException("databaseId");
-            if (connectionId == null) throw new ArgumentNullException("connectionId");
-            if (connection == null) throw new ArgumentNullException("connection");
+            if (databaseId == null) throw new ArgumentNullException(nameof(databaseId));
+            if (connectionId == null) throw new ArgumentNullException(nameof(connectionId));
+            if (connection == null) throw new ArgumentNullException(nameof(connection));
 
             AsyncSemaphore semaphore;
             _connectionSemaphores.TryGetValue(new ConnectionId(databaseId, connectionId, connection), out semaphore);
@@ -295,8 +295,8 @@ public static AsyncSemaphore GetProgramSemaphore(
             [NotNull] string databaseId,
             [NotNull] string programName)
         {
-            if (databaseId == null) throw new ArgumentNullException("databaseId");
-            if (programName == null) throw new ArgumentNullException("programName");
+            if (databaseId == null) throw new ArgumentNullException(nameof(databaseId));
+            if (programName == null) throw new ArgumentNullException(nameof(programName));
 
             AsyncSemaphore semaphore;
             _programSemaphores.TryGetValue(new Id(databaseId, programName), out semaphore);

Database/Configuration/DatabaseElement.cs

@@ -163,7 +163,7 @@ public async Task<SqlProgram> GetSqlProgram(
             TypeConstraintMode? constraintMode = null,
             CancellationToken cancellationToken = default(CancellationToken))
         {
-            if (name == null) throw new ArgumentNullException("name");
+            if (name == null) throw new ArgumentNullException(nameof(name));
 
             // Grab the default load balanced connection for the database.
             // ReSharper disable once PossibleNullReferenceException