Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove aesgcm header parser #28

Open
ghost opened this issue Apr 7, 2017 · 0 comments
Open

Remove aesgcm header parser #28

ghost opened this issue Apr 7, 2017 · 0 comments
Labels
enhancement

Comments

@ghost
Copy link

ghost commented Apr 7, 2017

ece_webpush_aesgcm_headers_extract_params uses a hand-rolled state machine parser. Parsing strings in C is scary, and Crypto-Key and Encryption are deprecated, anyway. It's better to use a higher-level language like Rust or Swift to extract the params, and pass them to ece_webpush_aes128gcm_decrypt.
ghost pushed a commit that referenced this issue Apr 7, 2017
Force callers to explicitly decode "aesgcm" params. See #28.
f7de207
@ghost ghost mentioned this issue Apr 8, 2017
Closed
@ghost ghost mentioned this issue May 28, 2017
Closed
@ghost ghost added the enhancement label May 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants