From ccf1744439f94057c72e62dcc22bbbabb4b37dfa Mon Sep 17 00:00:00 2001 From: Panagiotis Astithas Date: Fri, 20 Dec 2024 11:39:20 -0800 Subject: [PATCH] Add core WebAssembly tests to WPT (#49277) * Regularly add core WebAssembly tests to WPT * Fix Wasm spelling * Address review feedback - Add myself as a reviewer for .github/ - Remove the path fix up step as it's now done by build.py - Use better name for the wpt repo directory --- .github/META.yml | 1 + .github/workflows/update-wasm-tests.yml | 64 +++++++++++++++++++++++++ 2 files changed, 65 insertions(+) create mode 100644 .github/workflows/update-wasm-tests.yml diff --git a/.github/META.yml b/.github/META.yml index 9ecc0df746bc08..3f67bcd00ad563 100644 --- a/.github/META.yml +++ b/.github/META.yml @@ -1,3 +1,4 @@ suggested_reviewers: - foolip - jgraham + - past diff --git a/.github/workflows/update-wasm-tests.yml b/.github/workflows/update-wasm-tests.yml new file mode 100644 index 00000000000000..283e6e728786fd --- /dev/null +++ b/.github/workflows/update-wasm-tests.yml @@ -0,0 +1,64 @@ +name: Update Wasm tests + +on: + # Trigger at every Sunday UTC noon, or manually. + schedule: + - cron: 0 12 * * 0 + workflow_dispatch: + +jobs: + build-wpt: + runs-on: ubuntu-latest + steps: + - name: Checkout WPT repo + uses: actions/checkout@v4 + with: + path: wpt + - name: Checkout Wasm repo + uses: actions/checkout@v4 + with: + repository: WebAssembly/spec + path: wasm-spec + - name: Setup OCaml + uses: ocaml/setup-ocaml@v3 + with: + ocaml-compiler: 4.14.x + - name: Setup OCaml tools + run: opam install --yes ocamlfind.1.9.5 js_of_ocaml.4.0.0 js_of_ocaml-ppx.4.0.0 + - name: Build interpreter + run: cd wasm-spec/interpreter && opam exec make + - name: Convert WAST tests to WPT + run: wasm-spec/test/build.py --dont-recompile --html wasm-spec/out/ + - name: Copy Wasm tests to WPT + # Replace wasm/core entirely. + run: | + rm -rf wpt/wasm/core + cp -r wasm-spec/out/ wpt/wasm/core/ + - name: Commit changes + id: commit + continue-on-error: true + run: | + cd wpt + export BRANCH_NAME="$BRANCH_PREFIX-$(date +'%Y%m%d%H%M%S')" + echo "BRANCH_NAME=$BRANCH_NAME" >> $GITHUB_ENV + git config user.name "$GIT_AUTHOR_NAME" + git config user.email "$GIT_AUTHOR_EMAIL" + git checkout -b $BRANCH_NAME + git add wasm/core/ + git commit -m "$COMMIT_TITLE" + env: + GIT_AUTHOR_NAME: "wpt-pr-bot" + GIT_AUTHOR_EMAIL: "wpt-pr-bot@users.noreply.github.com" + BRANCH_PREFIX: "wasm-update" + COMMIT_TITLE: "Update Wasm tests" + - name: Create PR + # Check outcome for success as continue-on-error will mask failure. + if: ${{ steps.commit.outcome == 'success' }} + run: | + cd wpt + git push --set-upstream origin $BRANCH_NAME + gh pr create --title "$COMMIT_TITLE" --body "$PR_BODY" --reviewer past + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + COMMIT_TITLE: "Update Wasm tests" + PR_BODY: "Scheduled weekly update auto-generated by the '${{ github.workflow }}' workflow."