From 2331838b392c5802a97e5623769e0ad0b7b7102f Mon Sep 17 00:00:00 2001
From: Joey Arhar <jarhar@chromium.org>
Date: Fri, 20 Dec 2024 11:46:44 -0800
Subject: [PATCH] Only update first appended <selectedcontent> element

Since we are only planning to support one <selectedcontent> element in
<select>, this patch only performs a clone into the first
<selectedcontent> in tree order.

This is in response to feedback here:
https://github.com/whatwg/html/pull/10633#discussion_r1834376985

This patch also removes the logic which clears <selectedcontent>
elements when they are removed/disconnected.

Change-Id: I1580ec9f12df463d1f5134905e3e527cfefa694d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6043186
Reviewed-by: David Baron <dbaron@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1399301}
---
 .../selectedcontent.tentative.html            | 79 ++++++++++++++++++-
 1 file changed, 77 insertions(+), 2 deletions(-)

diff --git a/html/semantics/forms/the-select-element/customizable-select/selectedcontent.tentative.html b/html/semantics/forms/the-select-element/customizable-select/selectedcontent.tentative.html
index eef68a9237fb7f..d32990515370ee 100644
--- a/html/semantics/forms/the-select-element/customizable-select/selectedcontent.tentative.html
+++ b/html/semantics/forms/the-select-element/customizable-select/selectedcontent.tentative.html
@@ -80,8 +80,8 @@
     'Clicking on an option element should update the <selectedcontent>.');
 
   selectedcontent.remove();
-  assert_equals(selectedcontent.innerHTML, '',
-    'Removing the <selectedcontent> from the <select> should make it clear its contents.');
+  assert_equals(selectedcontent.innerHTML, optionTwo.innerHTML,
+    'Removing the <selectedcontent> from the <select> should not make it clear its contents.');
   button.appendChild(selectedcontent);
   assert_equals(selectedcontent.innerHTML, optionTwo.innerHTML,
     'Re-inserting the <selectedcontent> should make it update its contents.');
@@ -96,3 +96,78 @@
   // TODO(crbug.com/336844298): Add tests for mutation records during parsing
 }, 'The <selectedcontent> element should reflect the HTML contents of the selected <option>.');
 </script>
+
+<select id=select2>
+  <button>
+    <selectedcontent></selectedcontent>
+  </button>
+  <option class=one>one</option>
+  <option class=two>two</option>
+  <option class=three>three</option>
+</select>
+
+<script>
+promise_test(async () => {
+  const select = document.getElementById('select2');
+  const button = select.querySelector('button');
+  const selectedcontent = select.querySelector('selectedcontent');
+  assert_equals(selectedcontent.textContent, 'one',
+    'selectedcontent should initially be one.');
+
+  const selectedcontent2 = document.createElement('selectedcontent');
+  button.appendChild(selectedcontent2);
+  select.value = 'two';
+  assert_equals(selectedcontent.textContent, 'two',
+    'First selectedcontent should be kept up to date.');
+  assert_equals(selectedcontent2.textContent, '',
+    'Second selectedcontent should not be kept up to date.');
+
+  button.insertBefore(selectedcontent2, selectedcontent);
+  select.value = 'one';
+  assert_equals(selectedcontent.textContent, '',
+    'Second selectedcontent in tree order should be cleared after another is inserted.');
+  assert_equals(selectedcontent2.textContent, 'one',
+    'First selectedcontent in tree order should be kept up to date.');
+
+  selectedcontent.textContent = 'two';
+  selectedcontent.remove();
+  assert_equals(selectedcontent.textContent, 'two',
+    'selectedcontent should not have its children modified after removal.');
+
+  select.value = 'three';
+  assert_equals(selectedcontent2.textContent, 'three',
+    'Remaining selectedcontent should be kept up to date.');
+  assert_equals(selectedcontent.textContent, 'two',
+    'Removed selectedcontent should not be kept up to date.');
+
+  button.insertBefore(selectedcontent, selectedcontent2);
+  assert_equals(selectedcontent.textContent, 'three',
+    'Inserted selectedcontent should be updated if it is the first in tree order.');
+  assert_equals(selectedcontent2.textContent, '',
+    'Second selectedcontent in tree order should be cleared when another is inserted.');
+
+  selectedcontent.remove();
+  assert_equals(selectedcontent2.textContent, 'three',
+    'Remaining selectedcontent should be updated when first in tree order is removed.');
+}, 'When there are multiple <selectedcontent> elements, only the one in tree order should be kept up to date.');
+
+promise_test(async () => {
+  const select = document.createElement('select');
+  select.innerHTML = '<option>one</option><option>two</option>';
+  const button = document.createElement('button');
+  select.appendChild(button);
+
+  const selectedcontent = document.createElement('selectedcontent');
+  button.appendChild(selectedcontent);
+  assert_equals(selectedcontent.textContent, '',
+    '<selectedcontent> should not be updated when appending to a disconnected select.');
+
+  select.value = 'two';
+  assert_equals(selectedcontent.textContent, '',
+    '<selectedcontent> should not be updated when changing value of a disconnected select.');
+
+  document.body.appendChild(select);
+  assert_equals(selectedcontent.textContent, 'two',
+    '<selectedcontent> should be updated when <select> is connected to the document.');
+}, '<seletedcontent> behavior in disconnected <select>.');
+</script>