Skip to content

Rewrite property-cascade.html with getComputedStyle() #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fred-wang opened this issue Oct 19, 2023 · 4 comments · Fixed by web-platform-tests/wpt#42623
Closed

Rewrite property-cascade.html with getComputedStyle() #588

fred-wang opened this issue Oct 19, 2023 · 4 comments · Fixed by web-platform-tests/wpt#42623
Labels
focus area: Custom Properties test-change-proposal Proposal to add or remove tests for an interop area

Comments

@fred-wang
Copy link

Test List

https://wpt.fyi/results/css/css-properties-values-api/property-cascade.html

Rationale

The following tests from css-properties-values-api rely on the
computedStyleMap() API from CSS Typed OM Level 1, which is being
proposed for interop 2024 in #490:

css/css-properties-values-api/typedom.html
css/css-properties-values-api/at-property-typedom.html
css/css-properties-values-api/property-cascade.html

The two first are really testing the Typed OM spec with registered
properties and are not labelled for interop 2023, so that's fine.
However, the last one is included in interop 2023 and fails in Firefox,
(which does not implement the computedStyleMap() API yet):

https://wpt.fyi/results/css/css-properties-values-api?q=label%3Ainterop-2023-property

Checking property-cascade.html in more details, computedStyleMap()
is really only used to get the computed value of sRGB colors, which
have the same used and resolved values. So getComputedStyle() can just
be used instead.

(After doing that, WebKit and Chrome still pass the tests, while
Firefox Nightly really fails because of it violates the actual
assertion being tested)
@fred-wang fred-wang added the test-change-proposal Proposal to add or remove tests for an interop area label Oct 19, 2023
fred-wang added a commit to web-platform-tests/wpt that referenced this issue Oct 19, 2023
@fred-wang
Rewrite property-cascade.html with getComputedStyle()
82712f6 
See web-platform-tests/interop#588
@fred-wang fred-wang mentioned this issue Oct 19, 2023
Merged
@nt1m
Copy link
Member

nt1m commented Oct 19, 2023

The change looks straightforward and uncontroversial to me.

@lilles @andruud Can you review this for Chromium?

@fred-wang
Copy link
Author

cc @emilio

@lilles
Copy link
Member

lilles commented Oct 20, 2023

Changing https://wpt.fyi/results/css/css-properties-values-api/property-cascade.html to use getComputedStyle for color lgtm.

@emilio
Copy link

emilio commented Oct 20, 2023

Yeah sounds good to me fwiw. Thanks Fred!

nt1m pushed a commit to web-platform-tests/wpt that referenced this issue Oct 20, 2023
@fred-wang
Rewrite property-cascade.html with getComputedStyle() (#42623)
0d569c2 
Fixes web-platform-tests/interop#588
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 1, 2023
@fred-wang @moz-wptsync-bot
Bug 1859959 [wpt PR 42623] - Rewrite property-cascade.html with getCo…
af724d8 
…mputedStyle(), a=testonly

Automatic update from web-platform-tests
Rewrite property-cascade.html with getComputedStyle() (#42623)

Fixes web-platform-tests/interop#588
--

wpt-commits: 0d569c25cc1d7265e8eb92ead6049600edef4a1b
wpt-pr: 42623
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Nov 8, 2023
@marco-c
Bug 1859959 [wpt PR 42623] - Rewrite property-cascade.html with getCo…
9879972 
…mputedStyle(), a=testonly

Automatic update from web-platform-tests
Rewrite property-cascade.html with getComputedStyle() (#42623)

Fixes web-platform-tests/interop#588
--

wpt-commits: 0d569c25cc1d7265e8eb92ead6049600edef4a1b
wpt-pr: 42623

UltraBlame original commit: 356d689d5441d068224f52a979715941a3172c61
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Nov 8, 2023
@marco-c
Bug 1859959 [wpt PR 42623] - Rewrite property-cascade.html with getCo…
d347e45 
…mputedStyle(), a=testonly

Automatic update from web-platform-tests
Rewrite property-cascade.html with getComputedStyle() (#42623)

Fixes web-platform-tests/interop#588
--

wpt-commits: 0d569c25cc1d7265e8eb92ead6049600edef4a1b
wpt-pr: 42623

UltraBlame original commit: 356d689d5441d068224f52a979715941a3172c61
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Nov 8, 2023
@marco-c
Bug 1859959 [wpt PR 42623] - Rewrite property-cascade.html with getCo…
506392d 
…mputedStyle(), a=testonly

Automatic update from web-platform-tests
Rewrite property-cascade.html with getComputedStyle() (#42623)

Fixes web-platform-tests/interop#588
--

wpt-commits: 0d569c25cc1d7265e8eb92ead6049600edef4a1b
wpt-pr: 42623

UltraBlame original commit: 356d689d5441d068224f52a979715941a3172c61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
focus area: Custom Properties test-change-proposal Proposal to add or remove tests for an interop area
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite property-cascade.html with getComputedStyle() web-platform-tests/wpt
4 participants
@fred-wang @lilles @emilio @nt1m