-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove transform tests failing across 3 engines? #100
Comments
Ideally rather than just removing them we'd figure out what the underlying issue is; if the tests are wrong we should replace them with correct tests, if the spec is wrong we should update it. If implementations are failing in different ways we may still have an interop problem here that shouldn't be brushed under the carpet. |
@jgraham I'm no transforms expert, but all 3 tests fail in the same way in all 3 browser engines, they display as blank rather than as a green square. |
So I've been hoping to take some time to improve interoperability here -- it's the next major thing I'd like to look at as editor of the transforms spec, as I mentioned in the last spec update. I'm not sure whether this issue is requesting:
I'm fine with the latter (given that we don't yet have a good enough spec to yield interop), but I'd prefer not to delete tests right now, since they help track some of the issues that we need to solve. I'd be ok with marking additional tests as tentative if that makes sense, and I'm also fine with not counting those tests towards interop-2022. (I actually do honestly expect to get to this before the end of this year, since I think it's currently the second large task on my todo list.) |
I'm pretty sure the proposal is just to remove them from interop-2022, not from the repo. And by the sounds of it that should be fine (we should probably have some rule requiring extra justification for including tentative tests so that we can look up the original motivation for including the test if this kind of question arises). |
Yes I'm suggesting to remove them from interop-2022 only. |
Seems like there's general consensus here, so I went ahead and did it |
Huh, I thought I did a few passes looking for tentative tests, but suppose I didn't really... This issue was on the agenda of #103 today and that was a chance for folks to voice concerns. There were none, so let's stick with dropping the tests. (Done in web-platform-tests/wpt-metadata#2926.) |
** Test List **
css/css-transforms/backface-visibility-hidden-004.tentative.html
css/css-transforms/backface-visibility-hidden-005.tentative.html
css/css-transforms/backface-visibility-hidden-animated-002.html
** Rationale **
The two first tests are tentative, so it may well be possible they are not up to date.
Not sure about the 3rd one.
The text was updated successfully, but these errors were encountered: