-
tl;dr
detailsI have seen some people debugging for not realizing And that's the case I meet:
rspack/crates/rspack_core/src/normal_module.rs Lines 636 to 645 in 2c4c1da You put the
The re-direct code looks like rspack/crates/rspack_core/src/module.rs Lines 155 to 158 in 2c4c1da The default implementation for rspack/crates/rspack_core/src/module.rs Lines 93 to 97 in 2c4c1da So, when you call trapsYou will fall into traps:
solutionI have talked about this with @h-a-n-a before, the idea of I wonder whether there are other solutions to achieve the same goal. After investigating the code, I found most of the problems are due to using Take this code as example rspack/crates/rspack_core/src/module_graph/mod.rs Lines 162 to 165 in 2c4c1da There's no need for returning The argument also applies to using |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 1 reply
-
For this question: |
Beta Was this translation helpful? Give feedback.
-
sync up: We would remove |
Beta Was this translation helpful? Give feedback.
sync up:
We would remove
impl Module for Box<dyn Module>
in the future but I don't have time now. I would create a good first issuein case anyone wants to do this.