Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(exernals): add hash to distinguish conflict id #8834

Merged
merged 1 commit into from
Dec 25, 2024
Merged

fix(exernals): add hash to distinguish conflict id #8834

merged 1 commit into from
Dec 25, 2024

Conversation

fi3ework
Copy link
Member

@fi3ework fi3ework commented Dec 24, 2024 •
edited
Loading

Summary

Fix web-infra-dev/rslib#580, port https://github.com/webpack/webpack/blob/7701ae43203e9d93d661c9a663c41fccd8e242aa/lib/ExternalModule.js#L239-L244 of webpack.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Dec 24, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 24, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 08a7c8c
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/676a84ef47d6f700082c95bb

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 24, 2024

CodSpeed Performance Report

Merging #8834 will not alter performance

Comparing rslib-580 (08a7c8c) with main (1ca49a8)

🎉 Hooray! codspeed-node just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 3 untouched benchmarks

@fi3ework fi3ework marked this pull request as ready for review December 24, 2024 11:10
@fi3ework fi3ework requested a review from ahabhgk December 24, 2024 11:10
@fi3ework fi3ework mentioned this pull request Dec 24, 2024
Draft
4 tasks
@ahabhgk ahabhgk merged commit 56a99b2 into main Dec 25, 2024
38 checks passed
@ahabhgk ahabhgk deleted the rslib-580 branch December 25, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees
No one assigned
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
2 participants
@fi3ework @ahabhgk