Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: configure the default assetPrefix for MF apps correctly #3757

Merged
merged 2 commits into from
Oct 19, 2024

Conversation

chenjiahan
Copy link
Member

Summary

The default asset prefix has been changed when using moduleFederation.options. These changes ensure that the assets of remote modules can be requested by consumer apps with the correct URL, and that the SPA URL fallback works as expected.

  • Only change the default asset prefix for MF provider apps.
  • Only change the default asset prefix in development mode (via dev.assetPrefix).
  • The default asset prefix has been changed from auto to true (equivalent to localhost:<port>)
  • Always prefer to use the dev.assetPrefix value set by user.

@nyqykk please take a look, I suppose these changes should be ported to @module-federation/rsbuild-plugin

Related Links

resolve: #3751

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit b2891b8
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/671230c211136e000821c975
😎 Deploy Preview https://deploy-preview-3757--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 80 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nyqykk
Copy link
Member

nyqykk commented Oct 18, 2024

ok i will port this to universe repo

@chenjiahan chenjiahan merged commit bb81fb0 into main Oct 19, 2024
9 checks passed
@chenjiahan chenjiahan deleted the mf_asset_prefix_1018 branch October 19, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Module Federation breaks publicPath / assetsPrefix
2 participants