Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-rsbuild): useDefineForClassFields in lit template #3530

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

chenjiahan
Copy link
Member

Summary

From https://lit.dev/docs/components/decorators/#earlier-decorator-proposals:

You should also ensure that the useDefineForClassFields setting is false.

Related Links

#3521

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Sep 22, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 29de8e5
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/66f026dcff317d00083f5652
😎 Deploy Preview https://deploy-preview-3530--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 83 (🟢 up 9 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 7bcb41b into main Sep 22, 2024
10 checks passed
@chenjiahan chenjiahan deleted the lit_define_0922 branch September 22, 2024 14:25
@9aoy 9aoy mentioned this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant