[Bug]: tools.swc.jsc.transform.react config overrides takes no effect

[SoonIter]

Version

System:
    OS: macOS 14.6.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 67.98 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Browsers:
    Chrome: 128.0.6613.120
    Chrome Canary: 130.0.6702.0
    Safari: 17.6
  npmPackages:
    @rsbuild/core: 1.0.1-rc.5 => 1.0.1-rc.5 
    @rsbuild/plugin-react: 1.0.1-rc.5 => 1.0.1-rc.5

Details

1. rsbuild.config.ts

export default defineConfig({
  plugins: [pluginReact()],
  tools: {
    swc: {
      jsc: {
        transform: {
          react: {
            runtime: 'classic',
          },
        },
      },
    },
  },
});

2. DEBUG=rsbuild rsbuild build

Reproduce link

https://github.com/SoonIter/rsbuild-tools-swc-issue-repro

Reproduce Steps

rsbuild/packages/core/src/plugins/swc.ts

Line 158 in 14c5a9e

const mergedSwcConfig = reduceConfigs({

1. pnpm install
2. DEBUG=rsbuild npx rsbuild build

[SoonIter]

overrided by @rsbuild/plugin-react

fixed by

export default defineConfig({
  plugins: [pluginReact({
    swcReactOptions: {
      runtime: 'classic'
    }
  })],
  tools: {
    // swc(config) {
    //   (((config.jsc ??= {}).transform ??= {}).react ??= {}).runtime =
    //     'classic';
    // },
  },
});

[SoonIter]

tools.swc should execute in the final stage just like tools.bundlerChain and tools.rspack

so pluginSwc should execute after pluginReact?

modernjs has no entry for modifying the options of pluginReact

@chenjiahan cc

[chenjiahan]

This is an order issue, I think we can try to let pluginReact to use tools.swc instead of using modifySwcLoaderOptions

[SoonIter]

This is an order issue, I think we can try to let pluginReact to use tools.swc instead of using modifySwcLoaderOptions

I cannot get isDev usingHMR in modifyRsbuildConfig 😂...

[chenjiahan]

Yes, let me think if there is a better way...