Why sha512 vs xxh128 in CacheStorage

[ruudk]

Why is sha512 used for storing, but xxh128 to get it? How will this ever work? I might be missing something here.

webauthn-framework/src/symfony/src/Security/Storage/CacheStorage.php

Lines 19 to 46 in 9b9e5da

	public function store(Item $item): void
	{
	$key = sprintf(
	'%s-%s',
	self::CACHE_PARAMETER,
	hash('sha512', $item->getPublicKeyCredentialOptions()->challenge)
	);
	$cacheItem = $this->cache->getItem($key);
	$cacheItem->set($item);
	$this->cache->save($cacheItem);
	}
	public function get(string $challenge): Item
	{
	$key = sprintf('%s-%s', self::CACHE_PARAMETER, hash('xxh128', $challenge));
	$cacheItem = $this->cache->getItem($key);
	if (! $cacheItem->isHit()) {
	throw new BadRequestHttpException('No public key credential options available.');
	}
	$item = $cacheItem->get();
	$this->cache->deleteItem($key);
	if (! $item instanceof Item) {
	throw new BadRequestHttpException('No public key credential options available.');
	}
	return $item;
	}

[Spomky]

Hi @ruudk,

This is a bug... Should be xxh128 everywhere