Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dynamic filters #1092

Open
dirkkul opened this issue Jun 3, 2024 · 0 comments
Open

Improve dynamic filters #1092

dirkkul opened this issue Jun 3, 2024 · 0 comments

Comments

@dirkkul
Copy link
Collaborator

dirkkul commented Jun 3, 2024

We currently allow to add multiple filters dynamically using Filter.all_of(..list..of..filters...).

However, users still need to handle the case that:

  • there are no filters (list is empty)
  • some of the filters are None

We should handle this case and:

  • filter None out
  • In case there are no filters, we return a Non-filter that works like any other of our filters (eg supports + and - with other filters). Internally they are then ignored
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant