Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spike] Investigate merging 2 repos #3576

Open
katya-makarevich opened this issue Mar 29, 2023 · 7 comments
Open

[Spike] Investigate merging 2 repos #3576

katya-makarevich opened this issue Mar 29, 2023 · 7 comments

Comments

@katya-makarevich
Copy link

katya-makarevich commented Mar 29, 2023

Outcome:

  • options to merge 2 repos OSS and Enterprise described on high level
  • approx. effort for each option with the strategy to execute
  • pros/cons vs current scenario in terms of current engineering pain points and other business opportunities
  • recommendation on whether to do it or not

Timebox:

  • 3 days
@JamWils
Copy link
Contributor

JamWils commented Mar 29, 2023

Also tackle #3003 in tandem with this spike.

@enekofb
Copy link
Contributor

enekofb commented May 11, 2023

  • licensing under entitlements
  • clear integration points between OSS and EE and how this situation enhances

@enekofb
Copy link
Contributor

enekofb commented May 11, 2023

@jpellizzari adding notes out of scoping conversation for q2 planning

@enekofb
Copy link
Contributor

enekofb commented May 11, 2023

@LappleApple just mentioned in our product engineering roundtable that we could leverage her opensource strategy experience ... i thought it would be useful here!

@lasomethingsomething
Copy link
Contributor

Heya, any news on this front? Do we have a timeline?

@jpellizzari
Copy link
Contributor

@LappleApple No timeline, still doing fact-finding on the "why/if" we should do this.

@jpellizzari jpellizzari removed their assignment Jun 7, 2023
@lasomethingsomething lasomethingsomething added severity/critical low < medium < high < critical complexity/L labels Jun 8, 2023
@jpellizzari
Copy link
Contributor

jpellizzari commented Jun 8, 2023

Things we will need to think about:

  • How do releases work?
  • How does installation work?
  • How do we "move" things over gradually?
  • How do we check entitlements securely?

On combining the UIs:

My recommended design would be to have multiple entry points, one for OSS, one for EE. It would look something like this:

https://github.com/jpellizzari/wego-repo-example/blob/d2a385572bd76bfef0fb8317aa1c0892a010c39e/ui/Core.tsx#L10

https://github.com/jpellizzari/wego-repo-example/blob/d2a385572bd76bfef0fb8317aa1c0892a010c39e/ui/Enterprise.tsx#L7

This would allow us to easily control which features show up. The backend logic would also be simple, as the backend server (nginx) would just need to decide which .html file to load. This would probably be done with different docker images at build time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants