Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Make target for building and pushing container images #3265

Open
makkes opened this issue Jan 12, 2023 · 0 comments
Open

Use Make target for building and pushing container images #3265

makkes opened this issue Jan 12, 2023 · 0 comments
Labels
ci exclude from release notes priority_medium Items we want to complete in the next 60 days

Comments

@makkes
Copy link
Member

makkes commented Jan 12, 2023

We have two different ways how the container images of Weave GitOps are built right:

  1. Using the GitHub Actions-specific docker/build-and-push action here
  2. Using Make targets here.

We should rather be using the Make targets in the release workflow, too, which has several benefits:

  1. Less difference between how images are built for development and for releases. This brings our local development process closer to what's actually released which will prevent bugs that only appear in released artifacts.
  2. Tooling will iteratively get to a better state overall. Right now it's only used for development and not as configurable as it should be (see clean up Docker targets in Makefile #3264 for an example) and what "matters" is that the release process works. If it's all in one, both are maintained at the same time.

A good example of this principle can be seen in the pipeline-controller's tooling here.

@makkes makkes changed the title Use Make target for building container images Use Make target for building and pushuing container images Jan 24, 2023
@makkes makkes changed the title Use Make target for building and pushuing container images Use Make target for building and pushing container images Jan 24, 2023
@yiannistri yiannistri added the priority_medium Items we want to complete in the next 60 days label Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci exclude from release notes priority_medium Items we want to complete in the next 60 days
Projects
None yet
Development

No branches or pull requests

4 participants