Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading react-router from v5 to v6. #3169

Closed
wants to merge 42 commits into from
Closed

Upgrading react-router from v5 to v6. #3169

wants to merge 42 commits into from

Conversation

ahussein3
Copy link
Contributor

How:

  • This will be achieved incrementally by adding the compatibility Package. By following This Guide

ahussein3 and others added 30 commits December 18, 2022 10:44
@ahussein3
setup router compitability package
c48a5d2
@ahussein3
Merge branch 'main' into UpgradeReactRouter-v5-to-v6
ebc2f35
refactor route to compatroute
fc9208d
Merge branch 'UpgradeReactRouter-v5-to-v6' of https://github.com/weav…
bc6b37a 
…eworks/weave-gitops into UpgradeReactRouter-v5-to-v6
@ahussein3
Merge branch 'main' into UpgradeReactRouter-v5-to-v6
7a02daa
@ahussein3
update path to be empty to be able to run with the compat route
a0f75c1
merge latest from main
c24c46b
refactor useHistory to useNavigate
a8f1314
clean state
70d2747
poking react router upgrade
71f3146
@foot
Update react-router again
8788b11
@foot
Merge remote-tracking branch 'origin/main' into UpgradeReactRouter-v5…
2bd29df 
…-to-v6
@foot
works
99cdf7f
@foot
half converted, maybe we go back to old api
16fd862
@foot
Revert "half converted, maybe we go back to old api"
6ea63d8 
This reverts commit 16fd862.
@foot
Back to the old api
dd53ec3
@foot
Update other components to use relative links
969a48d
@foot
Migrate history -> navigate
0b2ef02 
- Also remove yarn.lock file
@foot
Progress keeps happening
ad5845c
@yitsushi
docs: document how to set up Tekton with Pipeline promotion events
1f95d00 
Signed-off-by: Balazs Nadasdi <[email protected]>
@yitsushi @Callisto13
Apply suggestions from code review
b7cd8a4 
Co-authored-by: Claudia <[email protected]>
@makkes
another attempt to fix ARM builds
fe7c52e 
We're still seeing socket timeouts in CI and the interwebs suggest
reducing the maximum number of open sockets. Let's see if that helps
anything.

refs #3229
merge latest from main
aba201a
update package json
3639ffb
merge latest from main
06c9094
Update javascript library version to 0.17.0-rc.3
5a263bc
Update the helm reference
ea69beb
disable the make enterprise PR job
8b0b11f 
Signed-off-by: Chanwit Kaewkasi <[email protected]>
merge latest
194c3b2
merge latest from main
76c5ab9
@foot
Copy link
Contributor

foot commented May 10, 2023 •
edited by ahussein3
Loading

  • Applications / Sources should be in the bread crumbs on details
  • / should redirect to /applications

main:
image

image

@ahussein3 ahussein3 marked this pull request as ready for review May 10, 2023 12:55
@ahussein3 ahussein3 requested review from foot, joshri and opudrovs May 10, 2023 12:56
@lasomethingsomething
Copy link
Contributor

@ahussein3 @foot Is this still in progress?

@lasomethingsomething
Copy link
Contributor

Closing due to lack of activity and response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foot foot Awaiting requested review from foot

@joshri joshri Awaiting requested review from joshri

@opudrovs opudrovs Awaiting requested review from opudrovs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal to Upgrade from react-router v5 to v6
5 participants
@ahussein3 @foot @lasomethingsomething @yitsushi @makkes