Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface OCI artifact metadata in OCIRepository Sources > Details page #2527

Open
5 tasks
ozamosi opened this issue Aug 3, 2022 · 6 comments
Open
5 tasks
Labels
area/ui Issues that require front-end work priority_medium Items we want to complete in the next 60 days team/wild-watermelon type/enhancement New feature or request

Comments

@ozamosi
Copy link
Contributor

ozamosi commented Aug 3, 2022

Objective

To enrich the Sources > Details page for OCI Repositories with the remaining keys starting with org.opencontainers.image and help users track artefacts better.

User Story

  • As a WeGO user, I would like to access the metadata about my sources from the UI, so I don't need to self-support by trying to figure out Flux pull/diff/push artefact with my own labels.
  • As a WeGO user, I would like to access the metadata about my sources from the UI, so I can easily trace/navigate back from OCI to Git Repo.

Acceptance criteria (apply to both WGE and OSS)

  • Remainder of annotations presented in the Figma design appear in the UI.
  • Annotations are organized in a manner that helps the user to understand why we're showing them the information—ie under Source, Release, Provenance categories.
  • All featured links work, and take the user to the intended destinations.

Previous notes
Consider:

  • Green checkmark when the image is signed
  • Metadata from other layers
@JamWils
Copy link
Contributor

JamWils commented Aug 8, 2022

@ozamosi is this for helm specifically or does this extend to OCI sources as well?

@ozamosi
Copy link
Contributor Author

ozamosi commented Aug 9, 2022

Ah, the joy of tickets created mid-meeting… This is specifically for oci sources, intended as a follow-up to #2520.

#2520 is a "make it work" ticket - when that's resolved, OCI sources will/should look pretty much like helm repositories, thanks to the magic of copy and paste. However, that doesn't mean much thought has gone into how they should be displayed, or how to highlight the advantages of oci images compared to other distribution formats - in order to make #2520 actionable we decided to bump those things (such as the examples above) until we've had a conversation about what product wants.

@yiannistri yiannistri added the priority_medium Items we want to complete in the next 60 days label Jun 5, 2023
@lasomethingsomething lasomethingsomething added the area/ui Issues that require front-end work label Aug 24, 2023
@lasomethingsomething
Copy link
Contributor

Partly addressed. We’ve had requests to show more information from container images (the labels) which is the same as the “metadata for other layers” part of this issue.

@lasomethingsomething lasomethingsomething added type/enhancement New feature or request and removed type/epic labels Aug 31, 2023
@lasomethingsomething lasomethingsomething changed the title Improved OCI source support Surface OCI artifact metadata in OCIRepository Sources > Details page Oct 6, 2023
@lasomethingsomething
Copy link
Contributor

@mmoulian Heya, can you drop the Figma link here so we have it for this week's refinement?

@mmoulian
Copy link

@LappleApple here you have the link: https://www.figma.com/file/IVHnM9iyeFWpd11evtY8ux/Weave-GitOps?type=design&node-id=20647%3A77911&mode=design&t=bsOMq6bpXhTmIoua-1

@lasomethingsomething
Copy link
Contributor

TODO: Apply "smart detection" of the source code + revision. Wouldn't work for on-prem instances, but we could e.g. figure out that source points to https://github.com/some/repository, then make the revision clickable if it contains a SHA and link to https://github.com/some/repository/commit/

This may actually be a useful addition in the future: display the last event historically on the primary page (as most of the time this will tell what it's working on, did last, or what issue it's stuck on).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui Issues that require front-end work priority_medium Items we want to complete in the next 60 days team/wild-watermelon type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants