diff --git a/packages/libro-prompt-cell/src/module.ts b/packages/libro-prompt-cell/src/module.ts index 23949ef7..ead80dce 100644 --- a/packages/libro-prompt-cell/src/module.ts +++ b/packages/libro-prompt-cell/src/module.ts @@ -6,7 +6,6 @@ import { FormatterPromptMagicContribution } from './libro-formatter-prompt-magic import { LibroPromptCellCommandContribution } from './prompt-cell-command-contribution.js'; import { PromptCellContribution } from './prompt-cell-contribution.js'; import { LibroPromptCellModel } from './prompt-cell-model.js'; -import { LibroPromptOutputArea } from './prompt-cell-output-area.js'; import { LibroPromptCellModelFactory } from './prompt-cell-protocol.js'; import { PromptScript } from './prompt-cell-script.js'; import { LibroPromptCellView } from './prompt-cell-view.js'; @@ -18,7 +17,6 @@ export const LibroPromptCellModule = ManaModule.create() PromptScript, LibroPromptCellView, LibroPromptCellModel, - LibroPromptOutputArea, LibroPromptOutputMimeTypeContribution, LibroPromptCellCommandContribution, FormatterPromptMagicContribution, diff --git a/packages/libro-prompt-cell/src/prompt-cell-output-area.tsx b/packages/libro-prompt-cell/src/prompt-cell-output-area.tsx deleted file mode 100644 index 666b643b..00000000 --- a/packages/libro-prompt-cell/src/prompt-cell-output-area.tsx +++ /dev/null @@ -1,59 +0,0 @@ -// import { l10n } from '@difizen/mana-l10n'; -import type { IOutputAreaOption } from '@difizen/libro-core'; -import { LibroOutputArea } from '@difizen/libro-core'; -import type { IRenderMimeRegistry } from '@difizen/libro-jupyter'; -import { RenderMimeRegistry } from '@difizen/libro-jupyter'; -import type { ViewComponent } from '@difizen/mana-app'; -import { - useInject, - ViewInstance, - ViewRender, - prop, - view, - inject, - transient, - ViewOption, -} from '@difizen/mana-app'; -import React from 'react'; - -import './index.less'; - -export const LibroPromptOutputAreaRender = React.forwardRef( - function LibroPromptOutputAreaRender(_props, ref) { - const outputArea = useInject(ViewInstance); - const defaultRenderMime = useInject(RenderMimeRegistry); - - return ( -
- {outputArea.outputs.map((output) => { - if ( - defaultRenderMime.preferredMimeType(output) !== - 'application/vnd.libro.prompt+json' - ) { - return ; - } else { - return null; - } - })} -
- ); - }, -); - -@transient() -@view('libro-prompt-output-area') -export class LibroPromptOutputArea extends LibroOutputArea { - override view: ViewComponent = LibroPromptOutputAreaRender; - @prop() - promptExecutionTipVisiable = false; - @prop() - promptExecutionTipShown = true; - - constructor(@inject(ViewOption) option: IOutputAreaOption) { - super(option); - } - - setSqlExecutionTipVisiable = (value: boolean) => { - this.promptExecutionTipVisiable = value; - }; -} diff --git a/packages/libro-prompt-cell/src/prompt-cell-view.tsx b/packages/libro-prompt-cell/src/prompt-cell-view.tsx index 08a576e1..eb6b7026 100644 --- a/packages/libro-prompt-cell/src/prompt-cell-view.tsx +++ b/packages/libro-prompt-cell/src/prompt-cell-view.tsx @@ -11,10 +11,10 @@ import type { LibroCell, CellViewOptions, } from '@difizen/libro-core'; +import { LibroOutputArea } from '@difizen/libro-core'; import { CellService, LibroExecutableCellView, - LibroOutputArea, LibroViewTracker, EditorStatus, LirboContextKey, @@ -487,7 +487,8 @@ export class LibroPromptCellView extends LibroExecutableCellView { handleQueryResponse = (response: KernelMessage.IIOPubMessage) => { const msgType = response.header.msg_type; switch (msgType) { - case 'execute_result': { + case 'execute_result': + case 'display_data': { const payload = response as KernelMessage.IExecuteResultMsg; let content: string = payload.content.data['text/plain'] as string; if (content.slice(0, 1) === "'" || content.slice(0, 1) === '"') { diff --git a/packages/libro-prompt-cell/src/prompt-output-render.tsx b/packages/libro-prompt-cell/src/prompt-output-render.tsx index 62486885..241cdd94 100644 --- a/packages/libro-prompt-cell/src/prompt-output-render.tsx +++ b/packages/libro-prompt-cell/src/prompt-output-render.tsx @@ -34,7 +34,7 @@ export const PromptOutputRender: React.FC<{ return null; } - const { data } = model.data['application/vnd.libro.prompt+json'] as IMimeBundle; + const data = model.data['application/vnd.libro.prompt+json'] as IMimeBundle; if (!data) { return null;