Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExprEditor needs a uniform signal for change events #90

Open
nrusch opened this issue Mar 4, 2019 · 1 comment
Open

ExprEditor needs a uniform signal for change events #90

nrusch opened this issue Mar 4, 2019 · 1 comment

Comments

@nrusch
Copy link
Contributor

nrusch commented Mar 4, 2019

I'm working on a project that involves integrating the ExprEditor class into another application's UI, and I need to know when the expression text has changed in any way in order to dispatch change notifications to the host.

Currently, there seems to be no consistent signal emitted to indicate that the expression text has changed in some way; the only way to get a reliable notification is to manually hit Ctrl + Return.

A fairly straightforward (but possibly naive) approach to addressing this would be to call sendApply() from inside of exprChanged, but I wanted to solicit some more educated opinions here before going that route. Also, I think it might make to consider giving the signal a more self-documenting naming like exprChanged.

Any thoughts?

Thanks.

@davvid
Copy link
Member

davvid commented Jul 25, 2019

In that sense the apply() signal would become the uniform signal, which doesn't sound too bad.

If you wanted the signal to be emitted after the controls have been already been rebuilt then calling sendApply() at the end of rebuildControls() would be appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants