Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exception safety with smart pointers #104

Open
elfring opened this issue Oct 7, 2020 · 1 comment
Open

Improve exception safety with smart pointers #104

elfring opened this issue Oct 7, 2020 · 1 comment

Comments

@elfring
Copy link

elfring commented Oct 7, 2020

Would you like to wrap any pointers with the class template “std::unique_ptr”?

Update candidates:

@davvid
Copy link
Member

davvid commented Oct 9, 2020

Hmm, Qt object ownership is interesting.

https://doc.qt.io/qt-5/objecttrees.html

In hindsight, the ExprEditor would be better off passing this to the QTimer constructors so that we don't need to do anything in the destructor. unique_ptr wouldn't be appropriate there.

unique_ptr seems like it would be helpful for ExprStrSpec tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants