Skip to content
This repository was archived by the owner on Sep 8, 2022. It is now read-only.

Commit 2ddbc84

Browse files
committed
[jgitflow-maven-plugin] merging 'release/1.0.0' into 'master'
2 parents 55f727c + 81f8250 commit 2ddbc84

File tree

52 files changed

+637
-419
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

52 files changed

+637
-419
lines changed

.travis.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,16 @@
2020
language: java
2121

2222
jdk:
23-
- oraclejdk8
23+
- oraclejdk8
24+
- openjdk11
2425

2526
# Make sure travis can use container-based infrastructure
2627
sudo: false
2728

2829
install: "mvn -s ./.travis.maven-settings.xml clean"
2930

3031
script:
31-
- "mvn -s ./.travis.maven-settings.xml -Pcontinuous-integration -U -Dmaven.javadoc.skip=true install"
32+
- "mvn -s ./.travis.maven-settings.xml -Pcontinuous-integration -U install"
3233
# Remove wcm.io artefacts from repository before cache
3334
- rm -rf $HOME/.m2/repository/io/wcm
3435

README.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,8 @@
44

55
This project is an attempt to integrate Galen with Selenium and the other way around in a Maven project. It uses TestNG as a test runner. Galen and ExtentReports provide the reporting.
66

7-
To get an idea how it works, take a look at the [example projects] and test examples.
7+
To get an idea how it works, take a look at the [documentation].
88

9-
To integrate into your project you inherit from the [spec generation] and [UI testing] POMs.
109

11-
[example projects]: examples
12-
[spec generation]: integration/specs
13-
[UI testing]: integration/ui-tests
10+
[documentation]: http://qa.wcm.io/galenium/
11+

examples/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,15 @@
2323
<parent>
2424
<groupId>io.wcm.maven</groupId>
2525
<artifactId>io.wcm.maven.global-parent</artifactId>
26-
<version>23</version>
26+
<version>25</version>
2727
<relativePath />
2828
</parent>
2929

3030
<name>Galenium Examples</name>
3131
<groupId>io.wcm.qa</groupId>
3232
<artifactId>io.wcm.qa.galenium.examples</artifactId>
3333
<packaging>pom</packaging>
34-
<version>0.1.22</version>
34+
<version>1.0.0</version>
3535
<description>Test automation examples.</description>
3636

3737
<properties>

examples/specs/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,15 @@
2323
<parent>
2424
<groupId>io.wcm.qa</groupId>
2525
<artifactId>io.wcm.qa.galenium.integration.specs</artifactId>
26-
<version>0.1.22</version>
26+
<version>1.0.0</version>
2727
<relativePath>../../integration/specs</relativePath>
2828
</parent>
2929

3030
<name>Galenium Example Specs</name>
3131
<groupId>io.wcm.qa</groupId>
3232
<artifactId>io.wcm.qa.galenium.examples.specs</artifactId>
3333
<packaging>jar</packaging>
34-
<version>0.1.22</version>
34+
<version>1.0.0</version>
3535
<description>Test automation example Galen specs.</description>
3636

3737
<properties>

examples/tests/pom.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,15 @@
2323
<parent>
2424
<groupId>io.wcm.qa</groupId>
2525
<artifactId>io.wcm.qa.galenium.integration.ui-tests</artifactId>
26-
<version>0.1.22</version>
26+
<version>1.0.0</version>
2727
<relativePath>../../integration/ui-tests</relativePath>
2828
</parent>
2929

3030
<name>Galenium Example Tests</name>
3131
<groupId>io.wcm.qa</groupId>
3232
<artifactId>io.wcm.qa.galenium.examples.tests</artifactId>
3333
<packaging>jar</packaging>
34-
<version>0.1.22</version>
34+
<version>1.0.0</version>
3535
<description>Test automation example tests.</description>
3636

3737
<properties>
@@ -44,7 +44,7 @@
4444
<dependency>
4545
<groupId>io.wcm.qa</groupId>
4646
<artifactId>io.wcm.qa.galenium.examples.specs</artifactId>
47-
<version>0.1.22</version>
47+
<version>1.0.0</version>
4848
</dependency>
4949

5050
</dependencies>

examples/tests/src/main/java/io/wcm/qa/galenium/example/AbstractExampleBase.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@
1919
*/
2020
package io.wcm.qa.galenium.example;
2121

22-
import static io.wcm.qa.galenium.util.GaleniumContext.getDriver;
23-
2422
import io.wcm.qa.galenium.device.TestDevice;
2523
import io.wcm.qa.galenium.example.selectors.common.Page;
2624
import io.wcm.qa.galenium.example.selectors.common.Page.Navigation;
@@ -52,11 +50,6 @@ private void navShouldBeVisible() {
5250
Element.findOrFail(Page.NAVIGATION);
5351
}
5452

55-
protected void assertRelativePath(String relativePath) {
56-
String currentUrl = getDriver().getCurrentUrl();
57-
assertEquals(currentUrl, getBaseUrl() + relativePath, "relative path should be: '" + relativePath + "'");
58-
}
59-
6053
protected void clickConferenceNavLink() {
6154
Navigation.LINK_TO_CONFERENCE.click();
6255
}

examples/tests/src/test/java/io/wcm/qa/galenium/example/ImageComparisonIT.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,10 @@ private void checkVisually(Selector selector) {
7474
getDevice(),
7575
GalenHelperUtil.getSectionFilter(getDevice()),
7676
getValidationListener());
77-
handleLayoutReport("image_comparison_" + selector.elementName() + ".gspec", layoutReport);
77+
String specName = "image_comparison_" + selector.elementName() + ".gspec";
78+
String errorMessage = "FAILED: Layoutcheck " + specName + " with device " + getDevice();
79+
String successMessage = "successfully ran spec: " + specName;
80+
GalenLayoutChecker.handleLayoutReport(layoutReport, errorMessage, successMessage);
7881
}
7982

8083
private ImageComparisonValidationListener getValidationListener() {

examples/tests/src/test/java/io/wcm/qa/galenium/example/NavigationIT.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@
2525
import io.wcm.qa.galenium.device.TestDevice;
2626
import io.wcm.qa.galenium.providers.TestDeviceProvider;
2727
import io.wcm.qa.galenium.util.BrowserUtil;
28+
import io.wcm.qa.galenium.verification.driver.TitleAndUrlVerification;
29+
import io.wcm.qa.galenium.verification.util.Check;
2830

2931
/**
3032
* Example for pure Selenium test based on Galenium.
@@ -54,7 +56,7 @@ public void testNavigation() {
5456
getLogger().debug("exception when sleeping after click", ex);
5557
}
5658
}
57-
assertRelativePath(PATH_TO_CONFERENCE_PAGE);
59+
Check.verify(new TitleAndUrlVerification("conference"));
5860
}
5961

6062
}

examples/tests/src/test/java/io/wcm/qa/galenium/example/PageObjectIT.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
import io.wcm.qa.galenium.example.pageobjects.Stage;
3636
import io.wcm.qa.galenium.interaction.Aem;
3737
import io.wcm.qa.galenium.providers.TestDeviceProvider;
38+
import io.wcm.qa.galenium.util.GaleniumContext;
3839

3940
/**
4041
* Showcase page object approach.
@@ -64,6 +65,14 @@ public void testWithPageObjects() {
6465
checkFooter();
6566
}
6667

68+
private void assertEquals(int actual, int expected, String msg) {
69+
GaleniumContext.getAssertion().assertEquals(actual, expected, msg);
70+
}
71+
72+
private void assertEquals(String actual, String expected, String msg) {
73+
GaleniumContext.getAssertion().assertEquals(actual, expected, msg);
74+
}
75+
6776
private void checkFooter() {
6877
Footer footer = getHomepage().getFooter();
6978
List<FooterNavSection> navSections = footer.getNavSections();

0 commit comments

Comments
 (0)