forked from dpkp/kafka-python
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom SASL mechanisms #146
Closed
wbarnha
wants to merge
5
commits into
kafka-python-ng:master
from
mattoberle:feature/SASL-Extensions
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
03c357f
Support custom SASL mechanisms
mattoberle 7f262e0
Merge branch 'master' into feature/SASL-Extensions
wbarnha 82fae7a
Merge branch 'master' into feature/SASL-Extensions
wbarnha 035af5b
Merge branch 'master' into feature/SASL-Extensions
wbarnha ebcfcb1
Add test_msk.py by @mattoberle
wbarnha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
import logging | ||
|
||
from kafka.sasl import gssapi, oauthbearer, plain, scram | ||
|
||
log = logging.getLogger(__name__) | ||
|
||
MECHANISMS = { | ||
'GSSAPI': gssapi, | ||
'OAUTHBEARER': oauthbearer, | ||
'PLAIN': plain, | ||
'SCRAM-SHA-256': scram, | ||
'SCRAM-SHA-512': scram, | ||
} | ||
|
||
|
||
def register_mechanism(key, module): | ||
""" | ||
Registers a custom SASL mechanism that can be used via sasl_mechanism={key}. | ||
|
||
Example: | ||
import kakfa.sasl | ||
from kafka import KafkaProducer | ||
from mymodule import custom_sasl | ||
kafka.sasl.register_mechanism('CUSTOM_SASL', custom_sasl) | ||
|
||
producer = KafkaProducer(sasl_mechanism='CUSTOM_SASL') | ||
|
||
Arguments: | ||
key (str): The name of the mechanism returned by the broker and used | ||
in the sasl_mechanism config value. | ||
module (module): A module that implements the following methods... | ||
|
||
def validate_config(conn: BrokerConnection): -> None: | ||
# Raises an AssertionError for missing or invalid conifg values. | ||
|
||
def try_authenticate(conn: BrokerConncetion, future: -> Future): | ||
# Executes authentication routine and returns a resolved Future. | ||
|
||
Raises: | ||
AssertionError: The registered module does not define a required method. | ||
""" | ||
assert callable(getattr(module, 'validate_config', None)), ( | ||
'Custom SASL mechanism {} must implement method #validate_config()' | ||
.format(key) | ||
) | ||
assert callable(getattr(module, 'try_authenticate', None)), ( | ||
'Custom SASL mechanism {} must implement method #try_authenticate()' | ||
.format(key) | ||
) | ||
if key in MECHANISMS: | ||
log.warning('Overriding existing SASL mechanism {}'.format(key)) | ||
|
||
MECHANISMS[key] = module |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so much cleaner. Thank you for writing this.