Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't compile with latest wasix #44

Open
syrusakbary opened this issue Oct 1, 2022 · 2 comments
Open

Can't compile with latest wasix #44

syrusakbary opened this issue Oct 1, 2022 · 2 comments

Comments

@syrusakbary
Copy link
Member

Using latest wasmer wasix branch, the codebase doesn't compile in wasmer-web:

$ cd wasmer-web
$ npm install
$ npm run build
[...]
error[E0107]: missing generics for trait `VirtualBus`
   --> wasmer-os/src/eval/runtime.rs:141:6
    |
141 | impl VirtualBus
    |      ^^^^^^^^^^ expected 1 generic argument
    |
note: trait defined here, with 1 generic parameter: `T`
   --> /Users/syrusakbary/Development/wasmer/lib/vbus/src/lib.rs:28:11
    |
28  | pub trait VirtualBus<T>: fmt::Debug + Send + Sync + 'static
    |           ^^^^^^^^^^ -
help: add missing generic argument
    |
141 | impl VirtualBus<T>
    |      ~~~~~~~~~~~~~

error[E0107]: missing generics for trait `VirtualBusSpawner`
   --> wasmer-os/src/eval/runtime.rs:253:6
    |
253 | impl VirtualBusSpawner
    |      ^^^^^^^^^^^^^^^^^ expected 1 generic argument
    |
note: trait defined here, with 1 generic parameter: `T`
   --> /Users/syrusakbary/Development/wasmer/lib/vbus/src/lib.rs:42:11
    |
42  | pub trait VirtualBusSpawner<T> {
    |           ^^^^^^^^^^^^^^^^^ -
help: add missing generic argument
    |
253 | impl VirtualBusSpawner<T>
    |      ~~~~~~~~~~~~~~~~~~~~

error[E0107]: missing generics for trait `VirtualBus`
  --> wasmer-os/src/eval/runtime.rs:94:38
   |
94 |     fn bus<'a>(&'a self) -> &'a (dyn VirtualBus) {
   |                                      ^^^^^^^^^^ expected 1 generic argument
   |
note: trait defined here, with 1 generic parameter: `T`
  --> /Users/syrusakbary/Development/wasmer/lib/vbus/src/lib.rs:28:11
   |
28 | pub trait VirtualBus<T>: fmt::Debug + Send + Sync + 'static
   |           ^^^^^^^^^^ -
help: add missing generic argument
   |
94 |     fn bus<'a>(&'a self) -> &'a (dyn VirtualBus<T>) {
   |                                      ~~~~~~~~~~~~~

error[E0107]: missing generics for struct `SpawnOptions`
   --> wasmer-os/src/eval/runtime.rs:144:28
    |
144 |     fn new_spawn(&self) -> SpawnOptions {
    |                            ^^^^^^^^^^^^ expected 1 generic argument
    |
note: struct defined here, with 1 generic parameter: `T`
   --> /Users/syrusakbary/Development/wasmer/lib/vbus/src/lib.rs:108:12
    |
108 | pub struct SpawnOptions<T> {
    |            ^^^^^^^^^^^^ -
help: add missing generic argument
    |
144 |     fn new_spawn(&self) -> SpawnOptions<T> {
    |                            ~~~~~~~~~~~~~~~

error[E0107]: missing generics for struct `SpawnOptionsConfig`
   --> wasmer-os/src/eval/runtime.rs:169:50
    |
169 |     pub fn spawn(&mut self, name: &str, config: &SpawnOptionsConfig) -> Result<LaunchResult<EvalResult>, VirtualBusError>
    |                                                  ^^^^^^^^^^^^^^^^^^ expected 1 generic argument
    |
note: struct defined here, with 1 generic parameter: `T`
   --> /Users/syrusakbary/Development/wasmer/lib/vbus/src/lib.rs:48:12
    |
48  | pub struct SpawnOptionsConfig<T> {
    |            ^^^^^^^^^^^^^^^^^^ -
help: add missing generic argument
    |
169 |     pub fn spawn(&mut self, name: &str, config: &SpawnOptionsConfig<T>) -> Result<LaunchResult<EvalResult>, VirtualBusError>
    |                                                  ~~~~~~~~~~~~~~~~~~~~~

error[E0107]: missing generics for struct `SpawnOptionsConfig`
   --> wasmer-os/src/eval/runtime.rs:175:55
    |
175 |     fn spawn_internal(&mut self, name: &str, config: &SpawnOptionsConfig) -> Result<RuntimeProcessSpawned, VirtualBusError>
    |                                                       ^^^^^^^^^^^^^^^^^^ expected 1 generic argument
    |
note: struct defined here, with 1 generic parameter: `T`
   --> /Users/syrusakbary/Development/wasmer/lib/vbus/src/lib.rs:48:12
    |
48  | pub struct SpawnOptionsConfig<T> {
    |            ^^^^^^^^^^^^^^^^^^ -
help: add missing generic argument
    |
175 |     fn spawn_internal(&mut self, name: &str, config: &SpawnOptionsConfig<T>) -> Result<RuntimeProcessSpawned, VirtualBusError>
    |                                                       ~~~~~~~~~~~~~~~~~~~~~

error[E0107]: missing generics for struct `BusSpawnedProcess`
   --> wasmer-os/src/eval/runtime.rs:256:76
    |
256 |     fn spawn(&mut self, name: &str, config: &SpawnOptionsConfig) -> Result<BusSpawnedProcess, VirtualBusError>
    |                                                                            ^^^^^^^^^^^^^^^^^ expected 1 generic argument
    |
note: struct defined here, with 1 generic parameter: `T`
   --> /Users/syrusakbary/Development/wasmer/lib/vbus/src/lib.rs:199:12
    |
199 | pub struct BusSpawnedProcess<T> {
    |            ^^^^^^^^^^^^^^^^^ -
help: add missing generic argument
    |
256 |     fn spawn(&mut self, name: &str, config: &SpawnOptionsConfig) -> Result<BusSpawnedProcess<T>, VirtualBusError>
    |                                                                            ~~~~~~~~~~~~~~~~~~~~

error[E0107]: missing generics for struct `SpawnOptionsConfig`
   --> wasmer-os/src/eval/runtime.rs:256:46
    |
256 |     fn spawn(&mut self, name: &str, config: &SpawnOptionsConfig) -> Result<BusSpawnedProcess, VirtualBusError>
    |                                              ^^^^^^^^^^^^^^^^^^ expected 1 generic argument
    |
note: struct defined here, with 1 generic parameter: `T`
   --> /Users/syrusakbary/Development/wasmer/lib/vbus/src/lib.rs:48:12
    |
48  | pub struct SpawnOptionsConfig<T> {
    |            ^^^^^^^^^^^^^^^^^^ -
help: add missing generic argument
    |
256 |     fn spawn(&mut self, name: &str, config: &SpawnOptionsConfig<T>) -> Result<BusSpawnedProcess, VirtualBusError>
@john-sharratt
Copy link
Collaborator

That branch is stale as I am working of this branch:
https://github.com/wasmerio/ate/tree/slim

Note: It also needs this branch of wasmer which will need to be rebased with the multithreading merge that's going on
https://github.com/john-sharratt/wasmer/tree/wasix

@syrusakbary
Copy link
Member Author

I was actually already using the slim branch and the wasix one (in Wasmer: https://github.com/wasmerio/wasmer/tree/wasix .. it's just two commits behind your fork), but the issues where not fixed.
Were you able to successfully run npm run build inside of wasmer-web?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants