Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution to abstract the concept of Anomaly and Vulnerability #250

Open
polyedre opened this issue Feb 13, 2022 · 1 comment
Open

Contribution to abstract the concept of Anomaly and Vulnerability #250

polyedre opened this issue Feb 13, 2022 · 1 comment

Comments

@polyedre
Copy link
Contributor

In the attack module, some parameters are often used together in functions. For example:

await self.add_vuln_medium(
request_id=original_request.path_id,
category=NAME,
request=evil_request,
parameter=xss_param,
info=message,
wstg=WSTG_CODE
)

It seems that the two concepts of "vulnerability" and "anomaly" could benefit from being abstracted with a class. We could for example add a Vulnerability class, and a XSSVulnerability as a inherited class (an one for each vulnerability).

This could also help with the reporting, because each class could be responsible for formatting its instances into each format (txt, html, etc).

Would you be interested in seeing more contributions going this way?

@devl00p
Copy link
Contributor

devl00p commented Feb 13, 2022

Indeed I already thought of that formatting problem but not about classes inheritance fir vulnerabilities. It seems to be a good idea and of course I'm not against such contributions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants